Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized synchronizeVulnerability #4359

Merged
merged 2 commits into from
Nov 12, 2024

Commits on Nov 7, 2024

  1. Modified synchronizeVulnerability

        This modification is in order to avoid multiple writes
        and/or updates when there is no changes.
    
        Part of the logic in updateVulnerability was optimized.
        Add differ.applyIfChanged and callInTransaction.
    
        SynchronizeVulnerability returns null if there is nothing
        to synchronize.
    
        Some modifications were needed to couple with new logic.
        e.g. if (SynchronizeVulnerability = null) continue.
    
        Test are provided.
    
    Signed-off-by: Andres Tito <[email protected]>
    LaVibeX committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dae9220 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. According to nscuro suggestions

    -Remove unnecesary persistance in updateVulnerability function.
    -Return updated exisitingVulnerability in updateVulnerability
    -Remove return of empty vulnerability
    -Wrap synchronizedVUlnerability in callInTransaction to share
    same transaction.
    
    Signed-off-by: Andres Tito <[email protected]>
    LaVibeX committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f08804f View commit details
    Browse the repository at this point in the history