Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reWriteBatchedInserts Postgres JDBC driver option in tests #917

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 19, 2024

Description

As per JDBC driver documentation (https://jdbc.postgresql.org/documentation/use/):

This will change batch inserts from insert into foo (col1, col2, col3) values (1, 2, 3) into insert into foo (col1, col2, col3) values (1, 2, 3), (4, 5, 6) this provides 2-3x performance improvement

Indeed, per default even batched JDBC statements are executed one-by-one, somewhat defeating the purpose of batching in the first place. This option allows us to get the true benefit out of performing batch operations.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Sep 19, 2024
As per JDBC driver documentation (https://jdbc.postgresql.org/documentation/use/):

This will change batch inserts from insert into foo (col1, col2, col3) values (1, 2, 3) into insert into foo (col1, col2, col3) values (1, 2, 3), (4, 5, 6) this provides 2-3x performance improvement

Indeed, per default even batched JDBC statements are executed one-by-one, somewhat defeating the purpose of batching in the first place. This option allows us to get the true benefit out of performing batch operations.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added this to the 5.6.0 milestone Sep 19, 2024
@nscuro nscuro marked this pull request as ready for review September 19, 2024 16:07
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0d087e1) 21412 17650 82.43%
Head commit (a699c80) 21412 (+0) 17650 (+0) 82.43% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#917) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal merged commit 132bc02 into main Sep 20, 2024
9 checks passed
@sahibamittal sahibamittal deleted the reWriteBatchedInserts branch September 20, 2024 15:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants