Add Bluesky Url to Members Profile #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that the CI build is failing. I ran the build and tests locally and it worked. I’ll investigate what’s happening with CI tomorrow. |
ardalis
approved these changes
Oct 6, 2023
|
Looks good. I'll need to do a db change when I deploy and I may not get to that before next week but we'll see. Thanks! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -17,6 +17,7 @@ | |||
| private string _initialTwitchUrl = ""; | |||
| private string _initialYouTubeUrl = ""; | |||
| private string _initialTwitterUrl = ""; | |||
| private string _initialBlueskyUrl = ""; | |||
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note test
|
Converted to Draft just so it doesn't get merged until we're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Bluesky as a social media option on the Members page. I used a cloud icon since there’s not a specific Bluesky icon from font-awesome yet. Open to suggestions on changes if there’s another icon.