Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New form for shipping address is added to profile page #931

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

New form for shipping address is added to profile page #931

wants to merge 2 commits into from

Conversation

Rostech
Copy link
Contributor

@Rostech Rostech commented Sep 14, 2022 •
edited
Loading

Closes #203

  • Countries are provided from https://www.nuget.org/packages/ISO3166
  • Address is saved as a separate item
  • Address maps to Member.ShippingAddress
  • Text saying how address will be used is updated
    Animation

@Rostech Rostech marked this pull request as draft September 15, 2022 07:44
@Rostech Rostech marked this pull request as ready for review September 15, 2022 13:12
@snowfrogdev
Copy link
Contributor

@Rostech While you're waiting for @ardalis to review this, you could look into the comments auto-generated by CodeQL.
You have to go in the Files changed section of the PR to see them.
image

@Rostech
Copy link
Contributor Author

Rostech commented Sep 16, 2022

Thanks for the tip, @snowfrogdev! :)

@Rostech Rostech force-pushed the rostech/sipping-address branch 3 times, most recently from 11d042a to a7108e2 Compare September 19, 2022 08:40
@Rostech Rostech force-pushed the rostech/sipping-address branch from a7108e2 to 2bec08d Compare October 4, 2022 08:10
@Rostech
Copy link
Contributor Author

Rostech commented Oct 4, 2022

Hey, @ardalis 👋 😃
What do you think about this one?

@ardalis
Copy link
Collaborator

ardalis commented Oct 4, 2022

I like it just haven't had time to deploy the change (which merging will do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new Shipping Address form to Profile
3 participants
@Rostech @snowfrogdev @ardalis