fix: the notEqual operator for numbers when comparing against more th…

…an one value (#230) Fix: the notEqual operator for numbers had a bug when comparing against more than one value
DevCycleHQ · Dec 18, 2023 · 7e8f276 · 7e8f276
1 parent 18a65b4
commit 7e8f276
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/bucketing-lib.debug.wasm b/bucketing-lib.debug.wasm
diff --git a/bucketing-lib.release.wasm b/bucketing-lib.release.wasm
diff --git a/bucketing/segmentation.go b/bucketing/segmentation.go
@@ -262,6 +262,16 @@ func _checkNumberFilter(num float64, filterNums []float64, operator string) bool
 		return false
 	}
 
+	if operator == "!=" {
+		passesFilter := true
+		for _, filterNum := range filterNums {
+			if math.IsNaN(filterNum) || num == filterNum {
+				passesFilter = false
+			}
+		}
+		return passesFilter
+	}
+
 	// replace filterNums.some() logic
 	someValue := false
 	for _, filterNum := range filterNums {
@@ -271,8 +281,6 @@ func _checkNumberFilter(num float64, filterNums []float64, operator string) bool
 
 		if operator == "=" {
 			someValue = num == filterNum
-		} else if operator == "!=" {
-			someValue = num != filterNum
 		} else if operator == ">" {
 			someValue = num > filterNum
 		} else if operator == ">=" {

diff --git a/bucketing/segmentation_test.go b/bucketing/segmentation_test.go
@@ -1025,7 +1025,7 @@ func TestEvaluateOperator_MultiNotEqualCustomDataFilters(t *testing.T) {
 				SubType:    "customData",
 				Comparator: ComparatorNotEqual,
 			},
-			Values: []interface{}{float64(0)},
+			Values: []interface{}{float64(0), float64(1)},
 		},
 		DataKey:     "numKey",
 		DataKeyType: "Number",
@@ -1416,7 +1416,8 @@ func Test_CheckNumberFilter(t *testing.T) {
 		{num: 10, filterNums: []float64{15}, operator: "<=", want: true},
 
 		{num: 10, filterNums: []float64{5, 15}, operator: "!=", want: true},
-		{num: 10, filterNums: []float64{}, operator: "!=", want: false},
+		{num: 15, filterNums: []float64{5, 15}, operator: "!=", want: false},
+		{num: 10, filterNums: []float64{}, operator: "!=", want: true},
 		{num: 10, filterNums: []float64{math.NaN()}, operator: "!=", want: false},
 
 		{num: 10, filterNums: []float64{}, operator: "fakeop", want: false},