Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate cloud client implementation #245

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajwootto
Copy link
Contributor

@ajwootto ajwootto commented Apr 22, 2024

  • separate cloud client implementation from main client

@ajwootto ajwootto changed the title separate cloud client implementation chore: separate cloud client implementation Apr 22, 2024
@ajwootto ajwootto requested a review from JamieSinn April 22, 2024 16:37
IsNull: false,
}
}

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets separate the protobuf cleanup from this pr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the functions here were unused tho

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - but they're confusing to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants