chore: remove unused protobuf stuff #248
Conversation
ajwootto
commented
Apr 22, 2024
•
ajwootto
commented
- remove protobuf definitions that are unused
- remove unused methods
- rename tests and remove redundant test case
- clean up dependencies
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ajwootto - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| variableValue, err := c.VariableValue(user, "test", true) | ||
| fatalErr(t, err) | ||
| fmt.Println(variableValue) | ||
| } |
There was a problem hiding this comment.
suggestion (code_refinement): Renaming of test function should reflect the updated functionality.
Ensure the new test name accurately represents the test's scope and purpose, especially after significant codebase changes.
| } | |
| func TestClient_VariableLocalBehavior(t *testing.T) { |
| variableValue, err := c.VariableValue(user, "test", true) | ||
| fatalErr(t, err) | ||
| fmt.Println(variableValue) | ||
| } |
There was a problem hiding this comment.
suggestion (testing): Test function rename needs verification for coverage.
The renaming of TestClient_VariableLocalProtobuf to TestClient_VariableLocal suggests a shift in focus possibly due to the removal of protobuf dependencies. Please ensure that the new test name accurately reflects the test's purpose and that all necessary aspects are still being tested.
ajwootto
changed the title
