Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for alternate key bucketing #266

Merged
merged 4 commits into from
Aug 16, 2024
Merged

feat: Add support for alternate key bucketing #266

merged 4 commits into from
Aug 16, 2024

Conversation

kaushalkapasi
Copy link
Contributor

@kaushalkapasi kaushalkapasi commented Aug 16, 2024 •
edited
Loading

  • feat: add support for alternate key bucketing rollouts and random distributions
    • supports String, Number and Boolean types for alternate keys
  • chore: updates test data and test cases to ensure consistent bucketing for users with and without the alternate key defined

@kaushalkapasi kaushalkapasi requested review from JamieSinn and a team August 16, 2024 13:24
JamieSinn
JamieSinn reviewed Aug 16, 2024
View reviewed changes
bucketing/bucketing.go Outdated Show resolved Hide resolved
bucketing/bucketing.go Outdated Show resolved Hide resolved
@kaushalkapasi kaushalkapasi force-pushed the add-support-for-alternate-key-bucketing branch from 27309ea to dd0e778 Compare August 16, 2024 14:06
@JamieSinn
Copy link
Member

Do you want to also vbump the path for the configs with this change too?

@elliotCamblor
Copy link
Collaborator

Do you want to also vbump the path for the configs with this change too?

@JamieSinn I think we want to vbump the config path as its own PR because thats the true breaking change, and the versioned configs feature flag isnt on for all users yet

@JamieSinn
Copy link
Member

Kk

@kaushalkapasi kaushalkapasi force-pushed the add-support-for-alternate-key-bucketing branch from 50aceff to 7f3cbb6 Compare August 16, 2024 20:21
@kaushalkapasi kaushalkapasi merged commit 7475535 into main Aug 16, 2024
8 checks passed
@kaushalkapasi kaushalkapasi deleted the add-support-for-alternate-key-bucketing branch August 16, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieSinn JamieSinn JamieSinn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalkapasi @JamieSinn @elliotCamblor