Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event 구조 및 생성 기능 #38

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Event 구조 및 생성 기능 #38

wants to merge 12 commits into from

Conversation

RbertKo
Copy link
Contributor

@RbertKo RbertKo commented Aug 12, 2021

Description
필수 리뷰어: @RebirthLee


진행 배경

작업 목표

  • Event에 대한 구조를 잡고 이벤트 (커리큘럼) 생성 API를 개발합니다.

결과

변경 후

  • POST /event 시 생성

어려웠던 점

  • 이거 계속 막혔던 부분 중에 하나가 DB Column명이 중간에 바뀌었었나 보더군요 ㅜㅜㅜㅜ 그래서 제 DB에 해당 column들(generationid, late_diff_minutes 같은...?)들 때문에 에러가 발생했던거네요

레퍼런스

  • 내용, 실행 방법 및 확인 방버

기타

  • 내용

@RbertKo RbertKo added the :octocat: HellP 리뷰어 지정 label Aug 12, 2021
@RbertKo RbertKo self-assigned this Aug 12, 2021
@RbertKo RbertKo requested a review from 2rebi August 15, 2021 13:58
@@ -22,6 +22,8 @@ class SecurityConfig(
private val permitAllUrls = listOf(
PermitSet(HttpMethod.GET, "/favicon.ico"),

PermitSet(HttpMethod.POST, "/event"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

외부에서 접근 하면 안되는 함수이므로 좋지 않습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RebirthLee 따로 멘션이나 알람이 없어서 지금봤네요 ㅜㅜ 관련해서 반영하겠습니다 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:octocat: HellP 리뷰어 지정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants