feat: partner w/ us #248
Closed
feat: partner w/ us #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
okhaimie-dev
requested review from
Markkos89,
wolovim,
kempsterrrr and
elPiablo
Markkos89
requested changes
Oct 4, 2023
Comment on lines
88
to
+90
| <Link | ||
| as={NextLink} | ||
| href="/lessons" | ||
| href="https://airtable.com/appDMMIARfSeiovpk/shrZExypPetXEx6Ox" |
There was a problem hiding this comment.
external links should use the normal anchor tag <a>
can you change it?? thanks !
Comment on lines
+94
to
+96
| router.pathname.startsWith( | ||
| 'https://airtable.com/appDMMIARfSeiovpk/shrZExypPetXEx6Ox', | ||
| ) |
There was a problem hiding this comment.
this variant ternary works for menu buttons, as this is an external link the ternary never will be true.
can you just set the variant to 'top-navigation' ? thanks!!
Comment on lines
+148
to
+150
| router.pathname.startsWith( | ||
| 'https://airtable.com/appDMMIARfSeiovpk/shrZExypPetXEx6Ox', | ||
| ) |
There was a problem hiding this comment.
same here, use and fixed variant style.
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New Features (required)](#246)
Connects #