Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: partner w/ us #248

Closed
wants to merge 1 commit into from
Closed

feat: partner w/ us #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions components/NavBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,20 +84,23 @@ function NavBar() {
GET STARTED
</Link>
</MenuItem>
{/* <MenuItem>
<MenuItem>
<Link
as={NextLink}
href="/lessons"
href="https://airtable.com/appDMMIARfSeiovpk/shrZExypPetXEx6Ox"
Comment on lines 88 to +90
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

external links should use the normal anchor tag <a>

can you change it?? thanks !

target="_blank"
passHref
variant={
router.pathname.startsWith('/lessons')
router.pathname.startsWith(
'https://airtable.com/appDMMIARfSeiovpk/shrZExypPetXEx6Ox',
)
Comment on lines +94 to +96
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this variant ternary works for menu buttons, as this is an external link the ternary never will be true.

can you just set the variant to 'top-navigation' ? thanks!!

? 'top-navigation-active'
: 'top-navigation'
}
>
Tracks
Partner with us
</Link>
</MenuItem> */}
</MenuItem>
</MenuList>
</Menu>
</Flex>
Expand Down Expand Up @@ -136,18 +139,21 @@ function NavBar() {
Get Started
</Link>

{/* <Link
<Link
as={NextLink}
href="/lessons"
href="https://airtable.com/appDMMIARfSeiovpk/shrZExypPetXEx6Ox"
target="_blank"
passHref
variant={
router.pathname.startsWith('/lessons')
router.pathname.startsWith(
'https://airtable.com/appDMMIARfSeiovpk/shrZExypPetXEx6Ox',
)
Comment on lines +148 to +150
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, use and fixed variant style.

thanks!

? 'top-navigation-active'
: 'top-navigation'
}
>
Tracks
</Link> */}
Partner with us
</Link>

{/* <Button colorScheme="gray" variant="solid">
<ConnectButton chainStatus="icon" showBalance={false} />
Expand Down