Unified t8sg #771
Open
Unified t8sg #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard0su
reviewed
Feb 27, 2019
howard0su
reviewed
Feb 27, 2019
howard0su
reviewed
Feb 27, 2019
howard0su
reviewed
Feb 27, 2019
| @@ -31,15 +28,20 @@ | |||
| #define HAS_AUDIO_UART 1 | |||
| #define HAS_MUSIC_CONFIG 1 | |||
|
|
|||
| #define TXTYPE ((char *)0x08003150) | |||
There was a problem hiding this comment.
please add comment on this variable. it will be hard to figure out the meaning via the name without the context of bootloader.
howard0su
approved these changes
Feb 27, 2019
|
The transmitter log file header should be changed from 7e to other value distinct for each version of T8SG as they have different number of switches and because of this different log file structure. |
|
I think you are talking about #452 |
howard0su
approved these changes
Mar 1, 2019
| #ifndef _T8SG_TARGET_H_ | ||
| #define _T8SG_TARGET_H_ | ||
| #ifndef _T8SG_V2_PLUS_TARGET_H_ | ||
| #define _T8SG_V2_PLUS_TARGET_H_ | ||
|
|
||
| #define TXID 0x7e |
There was a problem hiding this comment.
Change to 0x18 for v1 and 0x28 for v2.
…uration to be enaled/disabled dynamically
PhracturedBlue
force-pushed
the
unified_t8sg
branch
from
3cfaac6 to
253c8fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will move the original t8sg target to t8sg_v1. The new 't8sg' target will only work with the new bootloader. When complete any Jumper tx with the new bootloader will be able to load the t8sg target and the firmware will figure out what model is in use and configure appropriately.