Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advcurve ui bugfix #997

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

eried
Copy link
Contributor

@eried eried commented Aug 9, 2020

There are some small details in the interface of mixer -> curves editor

  1. The titlebar is selectable but it is not in reality.
  2. The curve value should be selected by default

image

@eried eried force-pushed the advcurve-UI-bugfix branch from f8db078 to 493f7b6 Compare August 9, 2020 01:03
@eried
Copy link
Contributor Author

eried commented Aug 13, 2020

Oh I am noticing that my fix does not work for /320x240x16/.

Can anyone with those remotes that if they go into "Advanced curves" of a mixer like the one shown in the image on top, they can scroll between curve types?? I can fix this also there but I just need to confirm that it is also a problem there

@TheRealMoeder
Copy link
Contributor

From testing in the emulator on color displays the curve type also cannot be changed with in the curves editor.

@TheRealMoeder
Copy link
Contributor

Actually there is some behavior to the title bar in curve editor for both GUIs , as can be seen in the code. When in a multipoint curve type, you can immediatly change the number of curve points (3 through 12).

@TheRealMoeder TheRealMoeder removed the Bug label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants