Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complitable build for sdk 33 #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JesseCodeBones
Copy link

build shared lib for api level 33

@varundtsfi
Copy link
Collaborator

Its pending on me. I will add the remaining for to this PR.

Signed-off-by: chen ruixiang <[email protected]>
@JesseCodeBones
Copy link
Author

Its pending on me. I will add the remaining for to this PR.

I signed off the commit, you can refactor according to a proper design :)

@summerlife
Copy link

Hi,@pcrepieux @varundtsfi @JesseCodeBones
Can it be merged now? I'm having a "Segmentation fault" and need to build in debug mode, or get the symbol table.

summerlife

This comment was marked as outdated.

summerlife

This comment was marked as outdated.

@moumde
Copy link

moumde commented May 15, 2023

@JesseCodeBones Hello, could you please share the source code of 33 version and document a bit more how to build it for different architectures? We are working on minicap adaptation on Android U. It would be appreciated if you could provide some help.

@JesseCodeBones
Copy link
Author

@JesseCodeBones Hello, could you please share the source code of 33 version and document a bit more how to build it for different architectures? We are working on minicap adaptation on Android U. It would be appreciated if you could provide some help.

Hi the source code is included in this PR,
if you are facing segment fault issue, can you send me some log or core dump?
Thank you

@moumde
Copy link

moumde commented May 18, 2023

@JesseCodeBones Hello, could you please share the source code of 33 version and document a bit more how to build it for different architectures? We are working on minicap adaptation on Android U. It would be appreciated if you could provide some help.

Hi the source code is included in this PR, if you are facing segment fault issue, can you send me some log or core dump? Thank you

Hi, I put the minicap code in my AOSP tree (eg: in "external") and compile it with:
$ . build/envsetup.sh
$ lunch aosp_arm64-eng
$ make minicap -j8

Compilation passed, but I didn't get minicap.so. I didn't find it in the "out" path of aosp. My 'minicap' paths are organized like this

`

  • /external/minicap/src/minicap_33.cpp
  • /external/minicap/Android.bp or Android.mk
  • /external/minicap/mcdebug.h
  • /external/minicap/Minicap.hpp
    `

The code is similar to yours, but strangely I can't get the .so. I'm not familiar with Android, please advise if I make a simple mistake.

Thank you

@moumde
Copy link

moumde commented May 18, 2023

@JesseCodeBones Hello, could you please share the source code of 33 version and document a bit more how to build it for different architectures? We are working on minicap adaptation on Android U. It would be appreciated if you could provide some help.

Hi the source code is included in this PR, if you are facing segment fault issue, can you send me some log or core dump? Thank you

Hi, I put the minicap code in my AOSP tree (eg: in "external") and compile it with: $ . build/envsetup.sh $ lunch aosp_arm64-eng $ make minicap -j8

Compilation passed, but I didn't get minicap.so. I didn't find it in the "out" path of aosp. My 'minicap' paths are organized like this

`

  • /external/minicap/src/minicap_33.cpp
  • /external/minicap/Android.bp or Android.mk
  • /external/minicap/mcdebug.h
  • /external/minicap/Minicap.hpp
    `

The code is similar to yours, but strangely I can't get the .so. I'm not familiar with Android, please advise if I make a simple mistake.

Thank you

I just found out that this problem has been solved. It's strange that lib was not generated when I compiled AOSP, but it was generated by compiling minicap separately.

@JesseCodeBones
Copy link
Author

@JesseCodeBones Hello, could you please share the source code of 33 version and document a bit more how to build it for different architectures? We are working on minicap adaptation on Android U. It would be appreciated if you could provide some help.

Hi the source code is included in this PR, if you are facing segment fault issue, can you send me some log or core dump? Thank you

Hi, I put the minicap code in my AOSP tree (eg: in "external") and compile it with: $ . build/envsetup.sh $ lunch aosp_arm64-eng $ make minicap -j8
Compilation passed, but I didn't get minicap.so. I didn't find it in the "out" path of aosp. My 'minicap' paths are organized like this
`

  • /external/minicap/src/minicap_33.cpp
  • /external/minicap/Android.bp or Android.mk
  • /external/minicap/mcdebug.h
  • /external/minicap/Minicap.hpp
    `

The code is similar to yours, but strangely I can't get the .so. I'm not familiar with Android, please advise if I make a simple mistake.
Thank you

I just found out that this problem has been solved. It's strange that lib was not generated when I compiled AOSP, but it was generated by compiling minicap separately.

here is my steps:

  1. copy jni/minicap-shared/aosp-soong to aosp/external
  2. rename to minicap-shared
  3. run make minicap-shared -j$(nproc)
  4. shared file location: out/target/product/generic/system/lib/minicap-shared.so

@yetnelson
Copy link

hi @moumde , Could you share me your build for Android U?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants