🐛 Fix: Increase PID retrieval timeout for edge-cases #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some devices (Pixel 4XL) need more time to retrieve PID, in such cases when the retrieval failed - the whole stream is shutting down, therefore, connection with Minicap is lost which leads to constant empty screen on the Web UI. Signed-off-by: Mark Omarov <[email protected]>
koral--
approved these changes
Feb 1, 2022
gounthar
pushed a commit
to MerryKombo/stf
that referenced
this pull request
Mar 3, 2022
Some devices (Pixel 4XL) need more time to retrieve PID, in such cases when the retrieval failed - the whole stream is shutting down, therefore, connection with Minicap is lost which leads to constant empty screen on the Web UI. Signed-off-by: Mark Omarov <[email protected]> Co-authored-by: Mark Omarov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices (Pixel 4XL) need more time to retrieve PID, in such cases when the retrieval failed - the whole stream is shutting down, therefore, connection with Minicap is lost which leads to constant empty screen on the Web UI.
Here's the problem described: DeviceFarmer/minicap#17 (comment)