Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade node to latest version v17.9.0 #500

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

denis99999
Copy link

Signed-off-by: Denis Barbaron [email protected]

@denis99999
Copy link
Author

denis99999 commented Apr 12, 2022

Here are additional comments to the PR:

  • From now, it is possible to build STF using node versions >= 8.x.x until the latest one (currently v17.9.0), nevertheless it is recommended do not use node versions < 12 because some "unsupported engine" warning are fired during the build, althrough all seem to work well at execution stage.
  • Accordingly, Gulp and Webpack configuration files have been reviewed in deph, and if you want to run "gulp karma" you have to set the "OPENSSL_CONF=/dev/null" previously
  • If you are using nvm and you want to switch from a node version to another one, be sure to well clean your build environment previously, you can for example create an executable build script named stf-build.sh like this:
#!/bin/bash
export OPENSSL_CONF=/dev/null
nvm use $1
rm -rf ~/.cache/node-gyp/$(nvm current)/ ~/.node-gyp/$(nvm current)/ node_modules/ package-lock.json res/build res/bower_components res/test/PhantomJS*
#yarn install
npm install

and run it like this: # . stf-build.sh 17.9.0

@denis99999 denis99999 requested a review from koral-- April 12, 2022 09:46
res/test/karma.conf.js Outdated Show resolved Hide resolved
@denis99999
Copy link
Author

@koral--
Do you merge or it's me ?

@elcolto
Copy link

elcolto commented Apr 19, 2022

Will you publish a new release to npm with these changes?

@koral--
Copy link
Member

koral-- commented Apr 19, 2022

Yes, it will be published soon, after some PRs like that: #510 are merged.

@denis99999
Copy link
Author

@koral-- I currently review #510 and it is not curently mergeable, I think you should release now a 3.6.2 version!

@koral--
Copy link
Member

koral-- commented Apr 19, 2022

ok, thanks will do that ASAP

DaniilSmirnov pushed a commit to DaniilSmirnov/stf that referenced this pull request May 10, 2022
* upgrade node to latest version v17.9.0

Signed-off-by: Denis Barbaron <[email protected]>

* remove useless comments in karma configuration file

Signed-off-by: Denis Barbaron <[email protected]>
Signed-off-by: di.smirnov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants