-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to version 0.27.0 #17
base: master
Are you sure you want to change the base?
Conversation
0.27.0 or rather 0.26.0? Because v0.26.0 should also support Firefox ESR I just tested locally and v0.26.0 also works with Firefox 80. Though Firefox ESR users can force geckodriver-helper v0.24.0 |
Thank you @bragboy this solves the problem for me completely |
Solves for me as well. |
would be great to merge this as soon as possible 👍 |
For those waiting on this PR to be merged, the better option is to remove this gem altogether and instead use (under gem 'webdrivers', '~> 4.0' |
Thanks @bragboy ! I tried that.. I get this:
Do you think I'm possibly missing something else that you have? |
@bragboy , I used to use the webdrivers gem but kept running into issues with Chrome updates regularly breaking everything. Things have been working a lot smoother since switching over to the firefox Gecko drivers, and this gem is the easiest way to get it working on CI. |
This PR is hanging for two months. Are there any blockers or reasons to delay the merge? /CC @dmitryreznik |
@dmitryreznik friendly ping to merge this :) |
This PR has been sitting for three months now and I note that the main branch hasn't received a commit in at least two years. The library is under MIT license. I recommend that somebody who's interested in maintaining it fork this, mention it somewhere noticeable here for people to discover, and notify prominent upstream consumers of the fork. It's starting to look like this project is dead and will cause a decent amount of pain before it's eventually replaced or forked. @dmitryreznik Would love to hear you comment on this. |
I have forked this gem, incorporated this PR, upgraded further to 0.28, and published |
With the recent upgrade to Firefox 80, this P1 bug seems to be causing failures in some test runs. This will help resolve that failure.