Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1350: Display crystal snapshots even if zipped #807

Merged
merged 1 commit into from
Jul 23, 2024
Merged

LIMS-1350: Display crystal snapshots even if zipped #807

merged 1 commit into from
Jul 23, 2024

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1350

Summary:

Some crystal snapshots have been zipped (as .gz) on disk. They should still be viewable.
(NB this is not to do with diffraction images)

Changes:

  • Check for .gz files when saying whether snapshots exist
  • Serve up zipped files if only they exist

To test:

  • Go to a data collection where the snapshots have been zipped, eg /dc/visit/lb18145-238/id/8295770 (snapshots at /dls/i03/data/2022/lb18145-238/jpegs/TestProteinaseK/ProtK-x0638/ProtK-x0638_1_1_*.png.gz)
  • Check thumbnail snapshot appears, and when clicked, all 4 full size images are viewable by pressing right arrow
  • Check the images are cached in the browser if you scroll through them more than once
  • Go to a recent data collection where the snapshots are not zipped, repeat the checks

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R3.3 July 23, 2024 09:51
@ndg63276 ndg63276 merged commit b9be6ed into pre-release/2024-R3.3 Jul 23, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1350/display-snapshots-even-if-zipped branch August 12, 2024 14:41
ndg63276 added a commit that referenced this pull request Aug 12, 2024
@ndg63276
Merge 2024-R3.3 into master (#813)
c044628 
* LIMS-1370: Handle errors from the shipping service (#804)

* LIMS-1330: Use experimentTypeId if specified (#796)

* LIMS-1240: Dont use shortComments LIKE 'EDNA%' (#795)

* LIMS-1350: Display crystal snapshots even if zipped (#807)

* LIMS-1369: Make fault report titles editable (#802)

* LIMS-1341: Allow entry of SMILES codes (#793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @gfrn