Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1467: Allow lab contacts to have spaces in their names #843

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Oct 3, 2024

JIRA ticket: LIMS-1467

Summary:

Some people have spaces in their names, both given and family. This should be allowed in Synchweb.

Changes:

  • Update regex for familyname and givenname args in PHP
  • Update model for creating/editing lab contacts and dewar dispatch form
  • Ensure visitRequired matches dispatchDetailsRequired

To test:

  • Set $use_shipping_service_redirect = True; in config.php, use sample-shipping-test as the shipping service.
  • Create a lab contact with spaces in given and family name, check the GUI gives no errors, and the form submits ok
  • Edit the lab contact given and family name (still with spaces), check the form submits ok and edits persist
  • Add a shipment with your new lab contact as the outgoing and return contacts, click the "Dispatch" button, choose "Aruba" as the country (so as to not use the shipping service), check the form submits and the dewar is marked as dispatch requested
  • Add another shipment with the same lab contact, click "Dispatch" and then choose "United Kingdom" as the country, and then click Proceed. Check you are redirected to the shipping service.

@gfrn gfrn self-assigned this Oct 7, 2024
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.1 October 22, 2024 08:40
@ndg63276 ndg63276 merged commit 53ae0bb into pre-release/2024-R5.1 Oct 22, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1467/names-can-have-spaces branch October 22, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants