Backstage update #771
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "version": "1.35.0" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| import { createApp } from '@backstage/app-defaults'; | ||
| import { AppRouter, FlatRoutes } from '@backstage/core-app-api'; | ||
| import { | ||
| AlertDisplay, | ||
| OAuthRequestDialog, | ||
| SignInPage, | ||
| } from '@backstage/core-components'; | ||
| import { githubAuthApiRef } from '@backstage/core-plugin-api'; | ||
| import { apiDocsPlugin } from '@backstage/plugin-api-docs'; | ||
| import { | ||
| CatalogEntityPage, | ||
|
|
@@ -39,6 +44,22 @@ import { searchPage } from './components/search/SearchPage'; | |
| import { PrefixNavigate } from './components/utils/PrefixNavigate'; | ||
|
|
||
| const app = createApp({ | ||
| components: { | ||
| SignInPage: props => ( | ||
| <SignInPage | ||
| {...props} | ||
| providers={[ | ||
| 'guest', | ||
| { | ||
| id: 'github-auth-provider', | ||
| title: 'GitHub', | ||
| message: 'Sign in using GitHub', | ||
| apiRef: githubAuthApiRef, | ||
| }, | ||
| ]} | ||
| /> | ||
| ), | ||
|
Comment on lines
+48
to
+61
There was a problem hiding this comment. Am I correct in thinking this shows up before the user is able to perform any other action? If so, can we somehow make There was a problem hiding this comment. Yes it does, you have to click Enter as guest user when first launched. I don't know if that is possible, but I will investigate. There was a problem hiding this comment. Guests can go to We might need a custom auth resolver to automatically login as guest. This might also be a problem:
There was a problem hiding this comment. A custom auth resolver sounds like a good call The shared guest identity isn't an issue for us as we run backstage in an immutable configuration. If you were to allow people to edit things in the UI it would certainly be an issue |
||
| }, | ||
| apis, | ||
| bindRoutes({ bind }) { | ||
| bind(catalogPlugin.externalRoutes, { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a fake secret because the field has to be provided, but the server is unauthenticated.