-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM Fixes for ophyd async types mega merge #858
base: mx-bluesky_475_multi_centre_plan
Are you sure you want to change the base?
DNM Fixes for ophyd async types mega merge #858
Conversation
65bf6a3
to
303869f
Compare
431b950
to
1b5cfd6
Compare
1b5cfd6
to
9b8109d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mx-bluesky_475_multi_centre_plan #858 +/- ##
=================================================================
Coverage 95.19% 95.19%
=================================================================
Files 120 120
Lines 4997 4978 -19
=================================================================
- Hits 4757 4739 -18
+ Misses 240 239 -1 ☔ View full report in Codecov by Sentry. |
def6e22
to
3732d8f
Compare
uri = kwargs.get("uri") | ||
uri_or_prefix = uri or prefix | ||
kwargs_with_prefix_or_uri = dict(kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please better naming or typing, that uri_or_prefix: str for clarity
Fixes breakages in dodal for bluesky/ophyd-async#594
Note this fix depends on #814
TODO
assert_configuration()
in ophyd async not working for numpy arraysPMACStringFoo
devices need to be changed as Signals-inside-signals are no longer permittedFluorescenceDetectorControlState
needs to be either astr
-basedStrictEnum
with appropriate valuesInstructions to reviewer on how to test:
StrictEnum
/SubsetEnum
is appropriateChecks for reviewer
dodal connect ${BEAMLINE}