Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove i04-1 as it's unused and broken #872

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Remove i04-1 as it's unused and broken #872

merged 3 commits into from
Oct 28, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #871

Instructions to reviewer on how to test:

  1. Confirm tests still pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (ff12610) to head (b9f0ec8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   95.54%   95.53%   -0.02%     
==========================================
  Files         125      124       -1     
  Lines        5344     5304      -40     
==========================================
- Hits         5106     5067      -39     
+ Misses        238      237       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, there's a reference to i04_1 in the docs which I'll change now. What was broken about i04_1.py ?

@DominicOram
Copy link
Contributor Author

Looks okay, there's a reference to i04_1 in the docs which I'll change now. What was broken about i04_1.py ?

Any _1 beamlines don't work as we don't pick up the different prefix i.e. #760. It's not obvious because it's actually connecting to the i04 PVs when you run dodal connect i04-1. We don't actually do anything on i04_1 anyway so it seems a bit silly keeping it around when it's broken and not used.

@DominicOram DominicOram merged commit c217c07 into main Oct 28, 2024
18 of 19 checks passed
@DominicOram DominicOram deleted the 871_remove_i04_1 branch October 28, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove i04-1.py
2 participants