Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Bevy v0.11 #636

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Upgrade to Bevy v0.11 #636

merged 5 commits into from
Jul 25, 2023

Conversation

Indy2222
Copy link
Collaborator

@Indy2222 Indy2222 commented Jul 21, 2023 •
edited
Loading

@Indy2222 Indy2222 mentioned this pull request Jul 21, 2023
Merged
@Indy2222 Indy2222 force-pushed the feature/bevy-v0.11 branch 24 times, most recently from beae885 to e839969 Compare July 23, 2023 20:34
Zakru
Zakru reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@Zakru Zakru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inexperienced reviewer, but I went through this pretty thoroughly. Only a few things caught my eye, everything else looks pretty good to me.

crates/core/src/schedule.rs Outdated Show resolved Hide resolved
crates/gui/src/toast.rs Outdated Show resolved Hide resolved
crates/lobby_client/src/plugin.rs Outdated Show resolved Hide resolved
crates/menu/src/gamelisting.rs Outdated Show resolved Hide resolved
@Indy2222 Indy2222 marked this pull request as ready for review July 24, 2023 20:13
@Indy2222 Indy2222 merged commit 5f33e03 into DigitalExtinction:main Jul 25, 2023
7 checks passed
@Indy2222 Indy2222 deleted the feature/bevy-v0.11 branch July 25, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zakru Zakru Zakru approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Bevy v0.11
2 participants
@Indy2222 @Zakru