Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve minimap camera controls #642

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Improve minimap camera controls #642

merged 3 commits into from
Sep 7, 2023

Conversation

Zakru
Copy link
Contributor

@Zakru Zakru commented Jul 24, 2023

  • Minimap no longer registers camera input when mouse is pressed down elsewhere and brought over the minimap
  • Minimap camera responds to press instead of release
  • Camera can now be dragged across the minimap in addition to clicking

I felt that at least with the current system, these new camera controls don't fit the existing event model, so I separated them to handle raw mouse input.

Indy2222
Indy2222 requested changes Jul 24, 2023
View reviewed changes
crates/controller/src/hud/minimap/interaction.rs Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
@Zakru Zakru force-pushed the feature/minimap-improvements branch from 7adbac3 to 56f67c4 Compare July 27, 2023 20:08
Indy2222
Indy2222 requested changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@Indy2222 Indy2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left multiple comments, but nothing major.

crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
@Zakru Zakru force-pushed the feature/minimap-improvements branch from 56f67c4 to 4ac876e Compare September 3, 2023 23:14
Indy2222
Indy2222 requested changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@Indy2222 Indy2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor note, otherwise LGTM.

crates/controller/src/hud/minimap/interaction.rs Outdated Show resolved Hide resolved
@Zakru Zakru force-pushed the feature/minimap-improvements branch from 52aa6bf to 5dd2933 Compare September 7, 2023 14:06
@Zakru Zakru mentioned this pull request Sep 7, 2023
Open
@Zakru
Copy link
Contributor Author

Zakru commented Sep 7, 2023

Opened #715 based on release event issues

@Indy2222 Indy2222 merged commit 0202976 into DigitalExtinction:main Sep 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Indy2222 Indy2222 Indy2222 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zakru @Indy2222