Add tests for unfiled images using default schema #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you merge master, CI should pass. |
manthey
reviewed
Nov 11, 2022
tests/datastore.py
Outdated
| @@ -29,3 +37,11 @@ def get_url(self, fname): | |||
| base_url='https://data.kitware.com/api/v1/file/hashsum/{algo}/{hashvalue}/download', | |||
| registry=registry, | |||
| ) | |||
|
|
|||
| lowres_datastore = DKCPooch( | |||
There was a problem hiding this comment.
Is there a reason to create a second datastore? It looks like you enumerate the files you are using anyway.
Each utility function for provisioning web servers enumerates the files to use. Therefore they can share the data stores without necessarily sharing the files.
naglepuff
force-pushed
the
default-workflow-tests
branch
from
acd98bd to
3e11a11
Compare
manthey
reviewed
Nov 15, 2022
tests/test_web_client.py
Outdated
| @@ -3,7 +3,7 @@ | |||
| import pytest | |||
| from pytest_girder.web_client import runWebClientTest | |||
|
|
|||
| from .utilities import provisionBoundServer, resetConfig # noqa | |||
| from .utilities import provisionDefaultSchemaBoundServer, provisionBoundServer, resetConfig # noqa | |||
There was a problem hiding this comment.
isort wants these alphabetized. You can also run tox -e format.
manthey
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses (partially) #295
When using the default schema, images can be ingested into the
Unfileddirectory. Work in #310 and #260 allowed for manually refiling these images into theAvailableToProcessfolder. The changes here add tests for importing images using the default schema, refiling one image from the item view, and bulk refiling from theUnfiledfolder itself.The test data is on DKC and is comprised of low-res whole slide images.
@manthey I think these are a good start on capturing more workflows in tests, although I think they are far from complete. I think a follow up PR could more carefully test the OCR job (perhaps independently of the import process), but if you think there are any glaring omissions from this initial effort I would not mind adding them to this PR.