Click buffer of 10px - missing annotations #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cooperlab, @dgutman Do either of you think this should be a configurable setting? |
|
@ds2268 I like this. Should the value be different for tablets with styluses versus mice? Or, is a single value sufficient? I'm inclined to make it configurable, but 10 seems like a good default. |
|
10px works OK as a default. The configuration would be good if we can put it to Admin/plugins/HistomicsUI. There are always differences between different tablets/touch devices and this might be beneficial. |
|
I talked ***@***.*** about this, and agree this is useful. I think to keep
it simple is we can just add a configuration as you suggested in the plugin.
I don't **think** at least for now having it adapt / use a different
threshold depending on the device type is necessary as it adds a lot more
complexity...
But after seeing the issue in real life, I agree being able to tweak that
makes using point annotations much more efficient, particularly if the
labelled objects are super dense..
…On Tue, Jul 26, 2022 at 11:38 AM Dejan Štepec ***@***.***> wrote:
10px works OK as a default. The configuration would be good if we can put
it to Admin/plugins/HistomicsUI. There are always differences between
different tablets/touch devices and this might be beneficial.
—
Reply to this email directly, view it on GitHub
<#210 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFODTRZ4GP6WEWET3W7B5LVWAA7FANCNFSM54KYLELA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
David A Gutman, M.D. Ph.D.
Associate Professor of Neurology
Emory University School of Medicine
|
|
I think is valuable enough to merge as is. I'll make an issue to add a setting if we want to do that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was already discussed in #125 and it's almost urgent to have it, according to our labeling experience. Especially, when point annotations are required. This safety buffer is even more important if tablets and stylus pens are used. It greatly reduces the number of missed annotations to almost 0. It's a quick fix and maybe a dirty fix, but it does the job according to our field tests.