Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new annotation creation access flag #222

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

eagw
Copy link
Contributor

@eagw eagw commented Aug 17, 2022

Uses the new annotation creation access flag and endpoint from PR #937 in girder/large_image to check whether the "New" annotation button should be shown in the image viewer. Also prevents the access flag from appearing in the image viewer's individual annotation access control widget.

This PR should only be tested simultaneously with the annotation-access-flag branch from girder/large_image and merged after it has been merged.

Closes #201

@eagw eagw requested a review from manthey August 17, 2022 21:47
Copy link
Contributor

@manthey manthey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rerun CI once large_image 1.16.1 is on pypi. Once it passes, you can merge.

@eagw eagw merged commit d22f2a6 into master Aug 18, 2022
@eagw eagw deleted the annotation-access-flag branch August 18, 2022 18:10
eagw added a commit that referenced this pull request Aug 20, 2022
Fix issue with panel layout from new access flag use (PR #222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation permissions on items
2 participants