Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redacting on subdirs #178

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Allow redacting on subdirs #178

merged 5 commits into from
Jan 10, 2024

Conversation

naglepuff
Copy link
Collaborator

@naglepuff naglepuff commented Jan 4, 2024

Fix #170

Adds a new flag (-r or --recursive).

If this flag is provided to the imagedephi run command, then redaction will be performed on sub directories of the input directory. Additionally, the directory structure will be duplicated in the output directory.

@naglepuff naglepuff requested a review from manthey January 4, 2024 15:57
@manthey
Copy link
Contributor

manthey commented Jan 9, 2024

When you have --skip-rename turned on, it creates the directory structure (at least one deep) from the source, but the redacted files are not in those subdirectories.

@naglepuff
Copy link
Collaborator Author

When you have --skip-rename turned on, it creates the directory structure (at least one deep) from the source, but the redacted files are not in those subdirectories.

I forgot to update the parent directory of the output file when --skip-rename is used. I fixed that with 71119f8.

I also updated the test to make sure this interaction doesn't break in the future with 231f38c.

@naglepuff naglepuff merged commit 4442b52 into main Jan 10, 2024
4 checks passed
@naglepuff naglepuff deleted the 170-recursive-redaction branch January 10, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Recursive option when specifying input folder
2 participants