Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Socket.IO connection timeout #236

Merged
merged 9 commits into from
Feb 16, 2024
Merged

Fix Socket.IO connection timeout #236

merged 9 commits into from
Feb 16, 2024

Commits on Feb 2, 2024

  1. fix: wrong assumption that the timeoutId argument to clearTimeout… 

    … is always a `JS::Value` of type `JSVAL_TYPE_INT32`
    @Xmader
    Xmader committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    a001cca View commit details
    Browse the repository at this point in the history

  2. fix(XHR): do nothing instead of throwing a DOMException when settin… 

    …g `xhr.withCredentials`

Socket.IO would die in the middle between `xhr.open` and `xhr.send`
    @Xmader
    Xmader committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    320462f View commit details
    Browse the repository at this point in the history

  3. feat(XHR): implement xhr.withCredentials getter/setter

    @Xmader
    Xmader committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b463778 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. feat(XHR): support xhr.responseType to be "json"

    @Xmader
    Xmader committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    f14ae78 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. refactor: move clearTimeout argument checks to the JavaScript side

    @Xmader
    Xmader committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    fa94dae View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Merge branch 'main' into Xmader/fix/socketio-connection-timeout

    @philippedistributive
    philippedistributive authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    e4c40ac View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. refactor: return timeoutID using .setNumber()

    @Xmader
    Xmader committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b1c3b6b View commit details
    Browse the repository at this point in the history

  2. test(event-loop): complete TODO tests in test_event_loop.py

    @Xmader
    Xmader committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    5a25afd View commit details
    Browse the repository at this point in the history

  3. test(event-loop): loosen setTimeout(..., 0) timeout to 0.05s becaus… 

    …e it won't be precisely 0s
    @Xmader
    Xmader committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    4ac7aab View commit details
    Browse the repository at this point in the history