-
Notifications
You must be signed in to change notification settings - Fork 16
Pull Request Guidelines
Andreas edited this page Sep 25, 2015
·
5 revisions
These guidelines are for commits made to the Djenesis/contributr repo
- Does the PR pass all tests? Check Travis status for this build.
- Is the PR up to date with the
master
branch? - Are the PR commit messages well-written and verbose? Do they follow these guidelines?
- Does the PR reference the correct Issue?
- Do the code follow the PEP 8 style guide for Python?
- Have at least two people taken a look at the code and changes?
- Are there tests for newly introduced code? If not, it needs to be tested before merging into
master
.