Skip to content

Pull Request Guidelines

Andreas edited this page Sep 25, 2015 · 5 revisions

These guidelines are for commits made to the Djenesis/contributr repo

Checklist for accepting and submitting a pull request (PR)

  1. Does the PR pass all tests? Check Travis status for this build.
  2. Is the PR up to date with the master branch?
  3. Are the PR commit messages well-written and verbose? Do they follow these guidelines?
  4. Does the PR reference the correct Issue?
  5. Do the code follow the PEP 8 style guide for Python?
  6. Have at least two people taken a look at the code and changes?
  7. Are there tests for newly introduced code? If not, it needs to be tested before merging into master.

Some helpful literature: