-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #32901 from mdeweerd/qual/phan.2025.1.31
Qual: Fix notices, update baseline, enable PhanTypeMismatchArgument
- Loading branch information
Showing
44 changed files
with
1,225 additions
and
673 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |
| * Copyright (C) 2015-2024 Alexandre Spangaro <[email protected]> | ||
| * Copyright (C) 2018-2024 Frédéric France <[email protected]> | ||
| * Copyright (C) 2021 Waël Almoman <[email protected]> | ||
| * Copyright (C) 2024 MDW <[email protected]> | ||
| * Copyright (C) 2024-2025 MDW <[email protected]> | ||
| * | ||
| * This program is free software; you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
|
|
@@ -1563,14 +1563,14 @@ function initfieldrequired() { | |
| $fullname = $object->getFullName($langs); | ||
|
|
||
| if ($object->morphy == 'mor') { | ||
| $companyname = $object->company; | ||
| $companyname = (string) $object->company; | ||
| if (!empty($fullname)) { | ||
| $companyalias = $fullname; | ||
| $companyalias = (string) $fullname; | ||
| } | ||
| } else { | ||
| $companyname = $fullname; | ||
| if (!empty($object->company)) { | ||
| $companyalias = $object->company; | ||
| $companyalias = (string) $object->company; | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| <?php | ||
| /* Copyright (C) 2017-2020 Laurent Destailleur <[email protected]> | ||
| * Copyright (C) 2019-2024 Frédéric France <[email protected]> | ||
| * Copyright (C) 2025 MDW <[email protected]> | ||
| * | ||
| * This program is free software; you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
|
|
@@ -135,7 +136,7 @@ | |
| $formfile = new FormFile($db); | ||
|
|
||
| $title = $langs->trans('BOM'); | ||
| $help_url ='EN:Module_BOM'; | ||
| $help_url = 'EN:Module_BOM'; | ||
|
|
||
| llxHeader('', $title, $help_url, '', 0, 0, '', '', '', 'mod-bom page-net_needs'); | ||
|
|
||
|
|
@@ -330,7 +331,7 @@ | |
| if ($useunit) { | ||
| require_once DOL_DOCUMENT_ROOT.'/core/class/cunits.class.php'; | ||
| $unit = new CUnits($db); | ||
| $unit->fetch($elem['fk_unit']); | ||
| $unit->fetch((int) $elem['fk_unit']); | ||
| print(isset($unit->label) ? " ".$langs->trans(ucwords($unit->label))." " : ''); | ||
| } | ||
| print '</td>'; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| * Copyright (C) 2018-2025 Frédéric France <[email protected]> | ||
| * Copyright (C) 2023 Laurent Destailleur <[email protected]> | ||
| * Copyright (C) 2023 Joachim Kueter <[email protected]> | ||
| * Copyright (C) 2024 MDW <[email protected]> | ||
| * Copyright (C) 2024-2025 MDW <[email protected]> | ||
| * | ||
| * This program is free software; you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
|
|
@@ -597,7 +597,7 @@ function setPaymentType() | |
| array('type' => 'date', 'name' => 'clone_date_value', 'label' => $langs->trans("DateValue"), 'value' => -1), | ||
| array('type' => 'other', 'tdclass' => 'fieldrequired', 'name' => 'clone_accountid', 'label' => $langs->trans("BankAccount"), 'value' => $form->select_comptes($object->fk_account, "accountid", 0, '', 1, '', 0, 'minwidth200', 1)), | ||
| array('type' => 'text', 'name' => 'clone_amount', 'label' => $langs->trans("Amount"), 'value' => price($object->amount)), | ||
| array('type' => 'select', 'name' => 'clone_sens', 'label' => $langs->trans("Sens").' '.$set_value_help, 'values' => $sensarray, 'default' => $object->sens), | ||
| array('type' => 'select', 'name' => 'clone_sens', 'label' => $langs->trans("Sens").' '.$set_value_help, 'values' => $sensarray, 'default' => (string) $object->sens), | ||
| ); | ||
|
|
||
| print $form->formconfirm($_SERVER["PHP_SELF"].'?id='.$object->id, $langs->trans('ToClone'), $langs->trans('ConfirmCloneVariousPayment', $object->ref), 'confirm_clone', $formquestion, 'yes', 1, 350); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| * Copyright (C) 2012-2014 Raphaël Doursenaud <[email protected]> | ||
| * Copyright (C) 2023 Nick Fragoulis | ||
| * Copyright (C) 2024-2025 Frédéric France <[email protected]> | ||
| * Copyright (C) 2024 MDW <[email protected]> | ||
| * Copyright (C) 2024-2025 MDW <[email protected]> | ||
| * Copyright (C) 2024 Alexandre Spangaro <[email protected]> | ||
| * | ||
| * This program is free software; you can redistribute it and/or modify | ||
|
|
@@ -1984,7 +1984,7 @@ public function buildSwitzerlandQRString() | |
| $s .= dol_trunc($mysoc->country_code, 2, 'right', 'UTF-8', 1)."\n";*/ | ||
| } else { | ||
| $s .= "S\n"; | ||
| $s .= dol_trunc($mysoc->name, 70, 'right', 'UTF-8', 1)."\n"; | ||
| $s .= dol_trunc((string) $mysoc->name, 70, 'right', 'UTF-8', 1)."\n"; | ||
| $addresslinearray = explode("\n", $mysoc->address); | ||
| $s .= dol_trunc(empty($addresslinearray[1]) ? '' : $addresslinearray[1], 70, 'right', 'UTF-8', 1)."\n"; // address line 1 | ||
| $s .= dol_trunc(empty($addresslinearray[2]) ? '' : $addresslinearray[2], 70, 'right', 'UTF-8', 1)."\n"; // address line 2 | ||
|
|
@@ -2005,7 +2005,7 @@ public function buildSwitzerlandQRString() | |
| $s .= ($this->multicurrency_code ? $this->multicurrency_code : $conf->currency)."\n"; | ||
| // Buyer | ||
| $s .= "S\n"; | ||
| $s .= dol_trunc($this->thirdparty->name, 70, 'right', 'UTF-8', 1)."\n"; | ||
| $s .= dol_trunc((string) $this->thirdparty->name, 70, 'right', 'UTF-8', 1)."\n"; | ||
| $addresslinearray = explode("\n", $this->thirdparty->address); | ||
| $s .= dol_trunc(empty($addresslinearray[1]) ? '' : $addresslinearray[1], 70, 'right', 'UTF-8', 1)."\n"; // address line 1 | ||
| $s .= dol_trunc(empty($addresslinearray[2]) ? '' : $addresslinearray[2], 70, 'right', 'UTF-8', 1)."\n"; // address line 2 | ||
|
|
||
Oops, something went wrong.