-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #26920 use status instead of fk_statut #27929
FIX #26920 use status instead of fk_statut #27929
Conversation
Duplicating fields is never a good idea. It means we will get data in conflict. For a transition to rename a field we must first : Step 1 - Manage in php code the both property field ->fk_status and ->status and set old one as deprecated. Step 2 - when we are sure that step 1 is completed (we can use ->oldname and ->newname in code, for both create,update and read, with the same result), then in a next version n+x, we update field in database with the new name and update sql requests in core code. Step 3 - Then in a next version n+y, we remove the duplicated code related to fk_status. Currentlty, there is still work to do on step 1 |
I update #26920 we check tomorrow step 1 and 2 |
FIX #26920
Update SQL task field fk_statut in status
First pull request concerning issue #26920 , others will follow to complete the work (but better go step by step)