Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX TakePos barcode rule #31857

Merged
merged 2 commits into from
Nov 21, 2024
Merged

FIX TakePos barcode rule #31857

merged 2 commits into from
Nov 21, 2024

Conversation

lvessiller-opendsi
Copy link
Contributor

FIX TakePos barcode rule
Issue #30203

@rycks
Copy link
Contributor

rycks commented Nov 17, 2024

Hello,
i'm sorry but i'm in trouble because two years ago we did the opposite commit, please have a look here:

cad8b1e "Fix autoadd in basket after a search (only if search on barcode)"

what do you think about that ?

maybe i need more time to test and set up a dolibarr with that use case

@lvessiller-opendsi
Copy link
Contributor Author

@rycks
You're right I will see an another solution to do it.

@rycks
Copy link
Contributor

rycks commented Nov 21, 2024

note about quality : $term is most of the time used for session terminal number

image

then it could be a quality fix to change term= by something like search= or barcode= .... and a new variable $search or $barcode then $term will be only for terminal number

Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me (and "quality" note is a "global" remark)

@eldy eldy merged commit c12a7e1 into Dolibarr:18.0 Nov 21, 2024
4 checks passed
@lvessiller-opendsi lvessiller-opendsi deleted the 18.0_fix-i30203 branch November 22, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants