-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hook in facture/document #32242
Open
Expresion
wants to merge
8
commits into
Dolibarr:develop
Choose a base branch
from
Expresion:20.0
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix hook in facture/document #32242
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: avoid php8 warnings in the agenda module
Fix: php8 warnings in agenda module
Expresion
changed the title
Fix Hook in facture/document.php
Fix hook in facture/document.php
Dec 4, 2024
Expresion
changed the title
Fix hook in facture/document.php
Fix hook in facture/document
Dec 4, 2024
eldy
reviewed
Dec 9, 2024
htdocs/compta/facture/document.php
Outdated
* Actions | ||
*/ | ||
* Actions | ||
*/ | ||
|
||
include DOL_DOCUMENT_ROOT.'/core/actions_linkedfiles.inc.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this line, already on new line 99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, sorry my mistake
eldy
reviewed
Dec 9, 2024
eldy
added
PR to fix - Conflict or CI error to solve
The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts.
PR to fix - See feedback in comments
PR needs to be fixed to be integrated (some comments should describes the fix to do)
and removed
PR to fix - Conflict or CI error to solve
The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts.
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR to fix - See feedback in comments
PR needs to be fixed to be integrated (some comments should describes the fix to do)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.