Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Force the sales representative if they don't have permissions #32313

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

joseplluis
Copy link
Contributor

FIX Force the sales representative if they don't have permissions

Force the sales representative if they don't have permissions
@hregis
Copy link
Contributor

hregis commented Dec 10, 2024

@joseplluis If you want to limit to third parties to which the user is linked as a sales representative, you can disable this right:
"Extend access to all third parties AND their objects (not only third parties for which the user is linked as a sales representative)"

if a user does not have the right to see third parties he does not see third parties!

@joseplluis
Copy link
Contributor Author

@hregis yes, and this is the current bug, users with this permission disabled can see all thirdparties
In v19 it was working fine, but now is buggy since v20 yes
In this correction we are using !$user->hasRight('societe', 'client', 'voir') that is different from $user->hasRight('societe', 'lire')

@eldy eldy merged commit 62afaed into Dolibarr:develop Dec 13, 2024
2 of 3 checks passed
@joseplluis joseplluis deleted the patch-11 branch December 13, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants