FIX select group and severity search fields on ticket list #32411
Conversation
htdocs/ticket/list.php
Outdated
| @@ -856,11 +856,11 @@ | |||
| print '</td>'; | |||
| } elseif ($key == 'category_code') { | |||
| print '<td class="liste_titre'.($cssforfield ? ' '.$cssforfield : '').'">'; | |||
| $formTicket->selectGroupTickets(dol_escape_htmltag(empty($search[$key]) ? '' : $search[$key]), 'search_'.$key, '', 2, 1, 1, 0, (!empty($val['css']) ? $val['css'] : 'maxwidth150')); | |||
| $formTicket->selectGroupTickets(dol_escape_htmltag(empty($search[$key]) ? '' : $search[$key]), 'search_'.$key, '', 2, ' ', 1, 0, (!empty($val['css']) ? $val['css'] : 'maxwidth150')); | |||
There was a problem hiding this comment.
Why not keep parameter 1 instead of having HTML code for empty value ?
There was a problem hiding this comment.
You are right, it works with value '1'.'
htdocs/ticket/list.php
Outdated
| print '</td>'; | ||
| } elseif ($key == 'severity_code') { | ||
| print '<td class="liste_titre center'.($cssforfield ? ' '.$cssforfield : '').'">'; | ||
| $formTicket->selectSeveritiesTickets(dol_escape_htmltag(empty($search[$key]) ? '' : $search[$key]), 'search_'.$key, '', 2, 1, 1, 0, (!empty($val['css']) ? $val['css'] : 'maxwidth150')); | ||
| $formTicket->selectSeveritiesTickets(dol_escape_htmltag(empty($search[$key]) ? '' : $search[$key]), 'search_'.$key, '', 2, ' ', 1, 0, (!empty($val['css']) ? $val['css'] : 'maxwidth150')); |
There was a problem hiding this comment.
Why not keep parameter 1 instead of having HTML code for empty value ? (same case as above)
There was a problem hiding this comment.
You are right, it works with value '1'.'
eldy
added
the
Discussion
|
@eldy je sais que je ne suis pas présent à tous les devcamp et vue mes réactions parfois c'est peut-être mieux comme ça.... mais pourquoi il y a des versions comme la v18 qui bénéficient d'un traitement particulier lorsqu'il s'agit de backporter des corrections, voir des corrections qui me sont refusées quand c'est moi ? alors me demande pas quand, quoi, où... c'est un fait... Opendsi fait une version trafiqué à sa sauce et pourquoi il serait prioritaire pour bénéficier des backports alors que quand parfois je veux intégrer des évolutions bloquantes vis à vis de multicompany ceci m'est refusé... bref... je n'ai rien contre personne ! je veux juste que tout soit équitable pour tous ! ça va trop vite ! |
|
@hregis https://wiki.dolibarr.org/index.php?title=DevCamp_Lyon_2023_hiver#DOLIBARR_LTS If a you need to discuss this, could you do it on the forum ? Thanks. |
FIX select group and severity search fields on ticket list
issue #31619 (indicates 20.0, but I encountered it also on develop)
see also PR #32120 , which is similar but for ticket type, and brings more details.
group and severity must be set when creating/updating a ticket, and have a default value.
However, on search fields, we don't want to set the default value.
This PR sets the default value only if
$emptyis not set.These are the changes brought by this PR :
Had to recreate PR #32142 because the branch did not have the right name.
NB : this bug also exists in develop.