Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean phpstan baseline #32818

Merged
merged 19 commits into from
Jan 28, 2025
Merged

clean phpstan baseline #32818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1f02f68
clean phpstan baseline
frederic34 Jan 27, 2025
11cb628
clean phpstan baseline
frederic34 Jan 27, 2025
e0e03f1
fix phpstan
frederic34 Jan 27, 2025
fe2cdc4
fix phpstan
frederic34 Jan 27, 2025
306e66e
fix phpstan
frederic34 Jan 27, 2025
3770436
fix phpstan
frederic34 Jan 27, 2025
4616a2f
fix phpstan
frederic34 Jan 27, 2025
63b56ad
fix phpstan
frederic34 Jan 27, 2025
877b9dc
fix phpstan
frederic34 Jan 28, 2025
6fd7871
Merge remote-tracking branch 'upstream/develop' into clean_phpstan_ba…
frederic34 Jan 28, 2025
a8d35dc
fix phpstan
frederic34 Jan 28, 2025
8ba6443
fix phpstan
frederic34 Jan 28, 2025
2327066
fix phpstan
frederic34 Jan 28, 2025
c7aa6f9
fix phpstan
frederic34 Jan 28, 2025
4a08b6c
fix phpstan
frederic34 Jan 28, 2025
fefb112
Merge remote-tracking branch 'upstream/develop' into clean_phpstan_ba…
frederic34 Jan 28, 2025
612c26c
fix phpstan
frederic34 Jan 28, 2025
00249c9
fix phpstan
frederic34 Jan 28, 2025
64f1d96
fix phpstan
frederic34 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
882 changes: 15 additions & 867 deletions dev/build/phpstan/phpstan-baseline.neon
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions htdocs/core/class/commoninvoice.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Copyright (C) 2012 Cédric Salvador <[email protected]>
* Copyright (C) 2012-2014 Raphaël Doursenaud <[email protected]>
* Copyright (C) 2023 Nick Fragoulis
* Copyright (C) 2024 Frédéric France <[email protected]>
* Copyright (C) 2024-2025 Frédéric France <[email protected]>
* Copyright (C) 2024 MDW <[email protected]>
* Copyright (C) 2024 Alexandre Spangaro <[email protected]>
*
Expand Down Expand Up @@ -905,9 +905,9 @@ public function getArrayOfInvoiceSubtypes($mode = 0)
/**
* Return label of object status
*
* @param int $mode 0=long label, 1=short label, 2=Picto + short label, 3=Picto, 4=Picto + long label, 5=short label + picto, 6=Long label + picto
* @param integer $alreadypaid 0=No payment already done, >0=Some payments were already done (we recommend to put here amount paid if you have it, 1 otherwise)
* @return string Label of status
* @param int $mode 0=long label, 1=short label, 2=Picto + short label, 3=Picto, 4=Picto + long label, 5=short label + picto, 6=Long label + picto
* @param int|float $alreadypaid 0=No payment already done, >0=Some payments were already done (we recommend to put here float amount paid if you have it, 1 otherwise)
* @return string Label of status
*/
public function getLibStatut($mode = 0, $alreadypaid = -1)
{
Expand All @@ -921,7 +921,7 @@ public function getLibStatut($mode = 0, $alreadypaid = -1)
* @param int $paye Status field paye (or $recur)
* @param int $status Id status
* @param int<0,6> $mode 0=long label, 1=short label, 2=Picto + short label, 3=Picto, 4=Picto + long label, 5=short label + picto, 6=long label + picto
* @param int $alreadypaid 0=No payment already done, >0=Some payments were already done (we recommend to put here amount paid if you have it, -1 otherwise)
* @param int|float $alreadypaid 0=No payment already done, >0=Some payments were already done (we recommend to put here float amount paid if you have it, -1 otherwise)
* @param int $type Type invoice. If -1, we use $this->type
* @param int $nbofopendirectdebitorcredittransfer Nb of open direct debit or credit transfer
* @return string Label of status
Expand Down
4 changes: 2 additions & 2 deletions htdocs/core/lib/pdf.lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1431,8 +1431,8 @@ function pdf_writeLinkedObjects(&$pdf, $object, $outputlangs, $posx, $posy, $w,
* @param CommonObject $object Object
* @param int $i Current line number
* @param Translate $outputlangs Object lang for output
* @param int $w Width
* @param int $h Height
* @param float $w Width
* @param float $h Height
* @param float $posx Pos x
* @param float $posy Pos y
* @param int<0,1> $hideref Hide reference
Expand Down
8 changes: 4 additions & 4 deletions htdocs/core/modules/bank/doc/pdf_ban.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/* Copyright (C) 2016 Laurent Destailleur <[email protected]>
* Copyright (C) 2024 MDW <[email protected]>
* Copyright (C) 2024 Frédéric France <[email protected]>
* Copyright (C) 2024-2025 Frédéric France <[email protected]>
* Copyright (C) 2024 Nick Fragoulis
*
* This program is free software; you can redistribute it and/or modify
Expand Down Expand Up @@ -284,9 +284,9 @@ public function write_file($object, $outputlangs)
* Show table for lines
*
* @param TCPDF $pdf Object PDF
* @param int $tab_top Top position of table
* @param int $tab_height Height of table (rectangle)
* @param int $nexY Y
* @param float $tab_top Top position of table
* @param float $tab_height Height of table (rectangle)
* @param float $nexY Y
* @param Translate $outputlangs Langs object
* @param int $hidetop Hide top bar of array
* @param int $hidebottom Hide bottom bar of array
Expand Down
14 changes: 7 additions & 7 deletions htdocs/core/modules/bank/doc/pdf_sepamandate.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/* Copyright (C) 2016 Laurent Destailleur <[email protected]>
* Copyright (C) 2020 Josep Lluís Amador <[email protected]>
* Copyright (C) 2024 MDW <[email protected]>
* Copyright (C) 2024 Frédéric France <[email protected]>
* Copyright (C) 2024-2025 Frédéric France <[email protected]>
* Copyright (C) 2024 Nick Fragoulis
*
* This program is free software; you can redistribute it and/or modify
Expand Down Expand Up @@ -485,9 +485,9 @@ public function write_file($object, $outputlangs, $srctemplatepath = '', $hidede
* Show table for lines
*
* @param TCPDF $pdf Object PDF
* @param int $tab_top Top position of table
* @param int $tab_height Height of table (rectangle)
* @param int $nexY Y
* @param float $tab_top Top position of table
* @param float $tab_height Height of table (rectangle)
* @param float $nexY Y
* @param Translate $outputlangs Langs object
* @param int $hidetop Hide top bar of array
* @param int $hidebottom Hide bottom bar of array
Expand All @@ -509,7 +509,7 @@ protected function _tableau(&$pdf, $tab_top, $tab_height, $nexY, $outputlangs, $
*
* @param TCPDF $pdf Object PDF
* @param CompanyBankAccount $object Object to show
* @param int $posy Y
* @param float $posy Y
* @param Translate $outputlangs Langs object
* @return float
*/
Expand Down Expand Up @@ -546,9 +546,9 @@ protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
*
* @param TCPDF $pdf Object PDF
* @param CompanyBankAccount $object Object invoice
* @param int $posy Position depart
* @param float $posy Position depart
* @param Translate $outputlangs Object langs
* @return int Position pour suite
* @return float Position pour suite
*/
protected function _signature_area(&$pdf, $object, $posy, $outputlangs)
{
Expand Down
14 changes: 7 additions & 7 deletions htdocs/core/modules/commande/doc/pdf_einstein.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* Copyright (C) 2012 Cedric Salvador <[email protected]>
* Copyright (C) 2015 Marcos García <[email protected]>
* Copyright (C) 2017-2018 Ferran Marcet <[email protected]>
* Copyright (C) 2018-2024 Frédéric France <[email protected]>
* Copyright (C) 2018-2025 Frédéric France <[email protected]>
* Copyright (C) 2024-2025 MDW <[email protected]>
* Copyright (C) 2024 Nick Fragoulis
* Copyright (C) 2024 Alexandre Spangaro <[email protected]>
Expand Down Expand Up @@ -714,9 +714,9 @@ protected function _tableau_versements(&$pdf, $object, $posy, $outputlangs)
*
* @param TCPDF $pdf Object PDF
* @param Commande $object Object to show
* @param int $posy Y
* @param float $posy Y
* @param Translate $outputlangs Langs object
* @return int
* @return float
*/
protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
{
Expand Down Expand Up @@ -898,11 +898,11 @@ protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
*
* @param TCPDF $pdf Object PDF
* @param Commande $object Object invoice
* @param int $deja_regle Montant deja regle
* @param int $posy Position depart
* @param float $deja_regle Montant deja regle
* @param float $posy Position depart
* @param Translate $outputlangs Object langs
* @param Translate $outputlangsbis Object lang for output bis
* @return int Position pour suite
* @return float Position pour suite
*/
protected function _tableau_tot(&$pdf, $object, $deja_regle, $posy, $outputlangs, $outputlangsbis = null)
{
Expand Down Expand Up @@ -1225,7 +1225,7 @@ protected function _tableau_tot(&$pdf, $object, $deja_regle, $posy, $outputlangs
* @param TCPDF $pdf Object PDF
* @param float|int $tab_top Top position of table
* @param float|int $tab_height Height of table (rectangle)
* @param int $nexY Y (not used)
* @param float $nexY Y (not used)
* @param Translate $outputlangs Langs object
* @param int $hidetop 1=Hide top bar of array and title, 0=Hide nothing, -1=Hide only title
* @param int $hidebottom Hide bottom bar of array
Expand Down
8 changes: 4 additions & 4 deletions htdocs/core/modules/contract/doc/pdf_strato.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Copyright (C) 2011 Fabrice CHERRIER
* Copyright (C) 2013-2024 Philippe Grand <[email protected]>
* Copyright (C) 2015 Marcos García <[email protected]>
* Copyright (C) 2018-2024 Frédéric France <[email protected]>
* Copyright (C) 2018-2025 Frédéric France <[email protected]>
* Copyright (C) 2024-2025 MDW <[email protected]>
* Copyright (C) 2024 Nick Fragoulis
* Copyright (C) 2024 Alexandre Spangaro <[email protected]>
Expand Down Expand Up @@ -526,7 +526,7 @@ public function write_file($object, $outputlangs, $srctemplatepath = '', $hidede
* @param TCPDF $pdf Object PDF
* @param float|int $tab_top Top position of table
* @param float|int $tab_height Height of table (rectangle)
* @param int $nexY Y
* @param float $nexY Y
* @param Translate $outputlangs Langs object
* @param int $hidetop Hide top bar of array
* @param int $hidebottom Hide bottom bar of array
Expand Down Expand Up @@ -578,8 +578,8 @@ protected function _tableau(&$pdf, $tab_top, $tab_height, $nexY, $outputlangs, $
* Show footer signature of page
*
* @param TCPDF $pdf Object PDF
* @param int $tab_top tab height position
* @param int $tab_height tab height
* @param float $tab_top tab height position
* @param float $tab_height tab height
* @param Translate $outputlangs Object language for output
* @return void
*/
Expand Down
6 changes: 3 additions & 3 deletions htdocs/core/modules/delivery/doc/pdf_storm.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* Copyright (C) 2015 Marcos García <[email protected]>
* Copyright (C) 2020 John BOTELLA
* Copyright (C) 2024-2025 MDW <[email protected]>
* Copyright (C) 2024 Frédéric France <[email protected]>
* Copyright (C) 2024-2025 Frédéric France <[email protected]>
* Copyright (C) 2024 Nick Fragoulis
*
* This program is free software; you can redistribute it and/or modify
Expand Down Expand Up @@ -608,7 +608,7 @@ public function write_file($object, $outputlangs, $srctemplatepath = '', $hidede
*
* @param TCPDF $pdf Object PDF
* @param Delivery $object Object to show
* @param int $posy Y
* @param float $posy Y
* @param Translate $outputlangs Langs object
* @return void
*/
Expand Down Expand Up @@ -639,7 +639,7 @@ protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
* @param TCPDF $pdf Object PDF
* @param float|int $tab_top Top position of table
* @param float|int $tab_height Height of table (rectangle)
* @param int $nexY Y (not used)
* @param float $nexY Y (not used)
* @param Translate $outputlangs Langs object
* @param int $hidetop 1=Hide top bar of array and title, 0=Hide nothing, -1=Hide only title
* @param int $hidebottom Hide bottom bar of array
Expand Down
6 changes: 3 additions & 3 deletions htdocs/core/modules/delivery/doc/pdf_typhon.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Copyright (C) 2011-2021 Philippe Grand <[email protected]>
* Copyright (C) 2015 Marcos García <[email protected]>
* Copyright (C) 2024-2025 MDW <[email protected]>
* Copyright (C) 2024 Frédéric France <[email protected]>
* Copyright (C) 2024-2025 Frédéric France <[email protected]>
* Copyright (C) 2024 Nick Fragoulis
*
* This program is free software; you can redistribute it and/or modify
Expand Down Expand Up @@ -609,7 +609,7 @@ public function write_file($object, $outputlangs, $srctemplatepath = '', $hidede
*
* @param TCPDF $pdf Object PDF
* @param Delivery $object Object to show
* @param int $posy Y
* @param float $posy Y
* @param Translate $outputlangs Langs object
* @return void
*/
Expand Down Expand Up @@ -639,7 +639,7 @@ protected function _tableau_info(&$pdf, $object, $posy, $outputlangs)
* @param TCPDF $pdf Object PDF
* @param float|int $tab_top Top position of table
* @param float|int $tab_height Height of table (rectangle)
* @param int $nexY Y (not used)
* @param float $nexY Y (not used)
* @param Translate $outputlangs Langs object
* @param int $hidetop 1=Hide top bar of array and title, 0=Hide nothing, -1=Hide only title
* @param int $hidebottom Hide bottom bar of array
Expand Down
10 changes: 5 additions & 5 deletions htdocs/core/modules/expedition/doc/pdf_espadon.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Copyright (C) 2005-2012 Laurent Destailleur <[email protected]>
* Copyright (C) 2005-2012 Regis Houssin <[email protected]>
* Copyright (C) 2014-2015 Marcos García <[email protected]>
* Copyright (C) 2018-2024 Frédéric France <[email protected]>
* Copyright (C) 2018-2025 Frédéric France <[email protected]>
* Copyright (C) 2023 Charlene Benke <[email protected]>
* Copyright (C) 2024 MDW <[email protected]>
* Copyright (C) 2024 Nick Fragoulis
Expand Down Expand Up @@ -831,10 +831,10 @@ public function write_file($object, $outputlangs, $srctemplatepath = '', $hidede
*
* @param TCPDF $pdf Object PDF
* @param Expedition $object Object expedition
* @param int $deja_regle Amount already paid
* @param int $posy Start Position
* @param float $deja_regle Amount already paid
* @param float $posy Start Position
* @param Translate $outputlangs Object langs
* @return int Position for suite
* @return float Position for suite
*/
protected function _tableau_tot(&$pdf, $object, $deja_regle, $posy, $outputlangs)
{
Expand Down Expand Up @@ -938,7 +938,7 @@ protected function _tableau_tot(&$pdf, $object, $deja_regle, $posy, $outputlangs
* @param TCPDF $pdf Object PDF
* @param float|int $tab_top Top position of table
* @param float|int $tab_height Height of table (rectangle)
* @param int $nexY Y
* @param float $nexY Y
* @param Translate $outputlangs Langs object
* @param int $hidetop Hide top bar of array
* @param int $hidebottom Hide bottom bar of array
Expand Down
10 changes: 5 additions & 5 deletions htdocs/core/modules/expedition/doc/pdf_rouget.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Copyright (C) 2005-2012 Laurent Destailleur <[email protected]>
* Copyright (C) 2005-2012 Regis Houssin <[email protected]>
* Copyright (C) 2014-2015 Marcos García <[email protected]>
* Copyright (C) 2018-2024 Frédéric France <[email protected]>
* Copyright (C) 2018-2025 Frédéric France <[email protected]>
* Copyright (C) 2024 MDW <[email protected]>
* Copyright (C) 2024 Nick Fragoulis
* Copyright (C) 2024 Alexandre Spangaro <[email protected]>
Expand Down Expand Up @@ -716,10 +716,10 @@ public function write_file($object, $outputlangs, $srctemplatepath = '', $hidede
*
* @param TCPDF $pdf Object PDF
* @param Expedition $object Object expedition
* @param int $deja_regle Amount already paid
* @param int $posy Start Position
* @param float $deja_regle Amount already paid
* @param float $posy Start Position
* @param Translate $outputlangs Object langs
* @return int Position for suite
* @return float Position for suite
*/
protected function _tableau_tot(&$pdf, $object, $deja_regle, $posy, $outputlangs)
{
Expand Down Expand Up @@ -832,7 +832,7 @@ protected function _tableau_tot(&$pdf, $object, $deja_regle, $posy, $outputlangs
* @param TCPDF $pdf Object PDF
* @param float|int $tab_top Top position of table
* @param float|int $tab_height Height of table (angle)
* @param int $nexY Y
* @param float $nexY Y
* @param Translate $outputlangs Langs object
* @param int $hidetop Hide top bar of array
* @param int $hidebottom Hide bottom bar of array
Expand Down
10 changes: 5 additions & 5 deletions htdocs/core/modules/expensereport/doc/pdf_standard_expensereport.modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/* Copyright (C) 2015 Laurent Destailleur <[email protected]>
* Copyright (C) 2015 Alexandre Spangaro <[email protected]>
* Copyright (C) 2016-2023 Philippe Grand <[email protected]>
* Copyright (C) 2018-2024 Frédéric France <[email protected]>
* Copyright (C) 2018-2025 Frédéric France <[email protected]>
* Copyright (C) 2018 Francis Appels <[email protected]>
* Copyright (C) 2019 Markus Welters <[email protected]>
* Copyright (C) 2019 Rafael Ingenleuf <[email protected]>
Expand Down Expand Up @@ -902,9 +902,9 @@ protected function _pagehead(&$pdf, $object, $showaddress, $outputlangs)
* Show table for lines
*
* @param TCPDF $pdf Object PDF
* @param int $tab_top Tab top
* @param int $tab_height Tab height
* @param int $nexY next y
* @param float $tab_top Tab top
* @param float $tab_height Tab height
* @param float $nexY next y
* @param Translate $outputlangs Output langs
* @param int $hidetop 1=Hide top bar of array and title, 0=Hide nothing, -1=Hide only title
* @param int $hidebottom Hide bottom bar of array
Expand Down Expand Up @@ -1025,7 +1025,7 @@ protected function _tableau(&$pdf, $tab_top, $tab_height, $nexY, $outputlangs, $
*
* @param TCPDF $pdf Object PDF
* @param ExpenseReport $object Object expensereport
* @param int $posy Position y in PDF
* @param float $posy Position y in PDF
* @param Translate $outputlangs Object langs for output
* @return int Return integer <0 if KO, >0 if OK
*/
Expand Down
Loading
Loading