Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI branch 21.0 #32928

Merged
merged 7 commits into from
Feb 4, 2025
Merged

fix CI branch 21.0 #32928

merged 7 commits into from
Feb 4, 2025

Conversation

frederic34
Copy link
Member

No description provided.

@mdeweerd
Copy link
Contributor

mdeweerd commented Feb 3, 2025

@frederic34 Thanks for fixing - howver there are 5 language files to fix in total:
https://github.com/Dolibarr/dolibarr/actions/runs/13116237093/job/36591654701#step:8:5202

And two other issues if they still exist:

There were 7 failures:

1) LangTest::testLang with data set "ca_ES" ('ca_ES')
Failed asserting that false is true.

D:\a\dolibarr\dolibarr\test\phpunit\LangTest.php:263

2) LangTest::testLang with data set "da_DK" ('da_DK')
Failed asserting that false is true.

D:\a\dolibarr\dolibarr\test\phpunit\LangTest.php:263

3) LangTest::testLang with data set "el_GR" ('el_GR')
Failed asserting that false is true.

D:\a\dolibarr\dolibarr\test\phpunit\LangTest.php:263

4) LangTest::testLang with data set "fr_CA" ('fr_CA')
Failed asserting that false is true.

D:\a\dolibarr\dolibarr\test\phpunit\LangTest.php:263

5) LangTest::testLang with data set "lv_LV" ('lv_LV')
Failed asserting that false is true.

D:\a\dolibarr\dolibarr\test\phpunit\LangTest.php:263

6) CodingSqlTest::testSql
Found double quote that is not [" neither {" (used for json content) neither (" (used for content with string like isModEnabled("")) into llx_accounting_account_fr.sql. Bad.
Failed asserting that false is true.

D:\a\dolibarr\dolibarr\test\phpunit\CodingSqlTest.php:171

7) CodingPhpTest::testPHP with data set #1375 (array('donstats.class.php', 'D:\a\dolibarr\dolibarr\htdocs.../class', 'class', 'don/class/donstats.class.php', 'D:\a\dolibarr\dolibarr\htdocs...ss.php', '', '', 'file'))
Found non sanitized string in building of a IN or NOT IN sql request don/class/donstats.class.php - Bad.
Failed asserting that false is true.

@frederic34
Copy link
Member Author

@mdeweerd I know 😢 for lang files
image

@eldy eldy merged commit ef50c66 into Dolibarr:21.0 Feb 4, 2025
6 checks passed
@frederic34 frederic34 deleted the patch-11 branch February 5, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants