properties

src/MeshIO.FBX.Tests/FbxReaderTest.cs

@@ -29,17 +29,6 @@ static FbxReaderTest()
 
 		public FbxReaderTest(ITestOutputHelper output) : base(output) { }
 
-		[Theory(Skip = "skipy skip")]
-		[MemberData(nameof(AsciiFiles))]
-		[MemberData(nameof(BinaryFiles))]
-		public void GetVersion(string path)
-		{
-			using (FbxReader reader = new FbxReader(path))
-			{
-				var version = reader.GetVersion();
-			}
-		}
-
 		[Theory]
 		[MemberData(nameof(AsciiFiles))]
 		public void ReadAsciiTest(string test)

src/MeshIO.FBX/FbxPropertyOld.cs

@@ -1,6 +1,6 @@
 using CSMath;
 using System;
-using System.Xml.Linq;
+using System.Collections.Generic;
 
 namespace MeshIO.FBX
 {
@@ -87,8 +87,12 @@ public Property ToProperty()
 		{
 			Property property = null;
 
-			object value = property.Value;
-			object[] arr = value as object[];
+			object value = this.Value;
+			List<object> arr = null;
+			if (value is IEnumerable<object> en)
+			{
+				arr = new List<object>(en);
+			}
 
 			switch ((string)this.FbxType)
 			{
@@ -104,12 +108,12 @@ public Property ToProperty()
 					g = (byte)(Convert.ToDouble(arr[1]) * 255);
 					b = (byte)(Convert.ToDouble(arr[2]) * 255);
 					byte a = (byte)(Convert.ToDouble(arr[3]) * 255);
-					property = new Property<Color>(this	.Name, Flags, new Color(r, g, b, a));
+					property = new Property<Color>(this.Name, Flags, new Color(r, g, b, a));
 					break;
 				case "Visibility":
 				case "Bool":
 				case "bool":
-					property = new Property<bool>(this.Name, Flags, Convert.ToInt32(arr[4]) != 0);
+					property = new Property<bool>(this.Name, Flags, Convert.ToInt32(value) != 0);
 					break;
 				case "Vector":
 				case "Vector3":
@@ -146,10 +150,9 @@ public Property ToProperty()
 					break;
 				case "Reference":
 				case "Compound":
-					property = new Property(this.Name, Flags, null);
-					break;
+				case "object":
 				default:
-					System.Diagnostics.Debug.Fail($"{arr[1]}");
+					property = new Property(this.Name, Flags, value);
 					break;
 			}
 

src/MeshIO.FBX/FbxReader.cs

@@ -33,15 +33,6 @@ public FbxReader(Stream stream)
 			this._stream = stream;
 		}
 
-		/// <summary>
-		/// Get the fbx version of the file
-		/// </summary>
-		/// <returns></returns>
-		public FbxVersion GetVersion()
-		{
-			throw new NotImplementedException();
-		}
-
 		/// <summary>
 		/// Read the FBX file
 		/// </summary>

src/MeshIO.FBX/Readers/FbxFileBuilderBase.cs

@@ -160,14 +160,22 @@ protected FbxProperty readFbxProperty(FbxNode node)
 			string type1 = node.GetProperty<string>(1);
 			string label = node.GetProperty<string>(2);
 			PropertyFlags flags = FbxProperty.ParseFlags(node.GetProperty<string>(3));
-			List<object> arr = new();
+			object value = null;
 
-			for (int i = 4; i < node.Properties.Count; i++)
+			if (node.Properties.Count == 5)
 			{
-				arr.Add(node.Properties[i]);
+				value = node.Properties[4];
+			}
+			else
+			{
+				value = new List<object>();
+				for (int i = 4; i < node.Properties.Count; i++)
+				{
+					(value as List<object>).Add(node.Properties[i]);
+				}
 			}
 
-			return new FbxProperty(name, type1, label, flags, arr);
+			return new FbxProperty(name, type1, label, flags, value);
 		}
 
 		protected void buildScene()

src/MeshIO.FBX/Readers/Templates/FbxNodeTemplate.cs

@@ -1,6 +1,9 @@
-using MeshIO.Entities;
+using CSMath;
+using CSUtilities.Extensions;
+using MeshIO.Entities;
 using MeshIO.FBX.Connections;
 using MeshIO.Shaders;
+using System.Collections.Generic;
 
 namespace MeshIO.FBX.Readers.Templates
 {
@@ -23,6 +26,16 @@ public override void Build(FbxFileBuilderBase builder)
 			this.processChildren(builder);
 		}
 
+		protected override void addProperties(Dictionary<string, FbxProperty> properties)
+		{
+			if(properties.Remove("Lcl Translation", out FbxProperty value))
+			{
+				this.Element.Transform.Translation = (XYZ)value.ToProperty().Value;
+			}
+
+			base.addProperties(properties);
+		}
+
 		protected void processChildren(FbxFileBuilderBase builder)
 		{
 			foreach (FbxConnection c in builder.GetChildren(this.TemplateId))

src/MeshIO.FBX/Readers/Templates/FbxObjectTemplate.cs

@@ -51,6 +51,8 @@ public virtual void Build(FbxFileBuilderBase builder)
 
 				nodeProp.Add(t.Key, t.Value);
 			}
+
+			this.addProperties(nodeProp);
 		}
 
 		protected string removePrefix(string fullname)