Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SMTPKit.com Template #579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JoaoBarrosJunho
Copy link

@JoaoBarrosJunho JoaoBarrosJunho commented Feb 8, 2025

Add smtpkit.com template

Description

Aiming to enhance our domain validation services, the SMTPKit team is submitting this template to streamline integration with Domain Connect. This addition ensures a smoother and more standardized implementation, improving compatibility with the platform’s services.

We appreciate your review and are available for any necessary adjustments.

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

Example variable values

<-- to make review process easier please provide example set of variable values for this template -->

<-- Example: -->

smtpkit_code: smtpkit-code:4e22f31e3032e7e7d86df7cabc1b8e24
spf_value: v=spf1 a mx include:smtpkit.com  include:*.smtpkit.com -all
dkim_selector: mail
dkim_public_key: v=DKIM1; k=rsa; p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC7vJ/Dgoaedp367Fc2xSwzq0liCrVTmLtGGa31D9V0NGu2usNFI+7sGyQQuSjfAsZvFJEdIHIDjA352hKFNuSwRL/517Q114x//alUCwvOx9n//b12N1Y0KGEpBvIDLWGgd1kpcN80Cowx0RLCxOB6KnUxsD0PBNknE5Uxjv9B1QIDAQAB
dmarc_value: v=DMARC1; p=quarantine; pct=100

<-- Or provide the whole testData object from the Online Editor after testing and using "Add as test" button -->

"testData": {
      "variables": {
        "domain": "example.com",
        "smtpkit_code": "smtpkit-code:4e22f31e3032e7e7d86df7cabc1b8e24",
        "dkim_selector": "mail",
        "dkim_public_key": "v=DKIM1; k=rsa; p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC7vJ/Dgoaedp367Fc2xSwzq0liCrVTmLtGGa31D9V0NGu2usNFI+7sGyQQuSjfAsZvFJEdIHIDjA352hKFNuSwRL/517Q114x//alUCwvOx9n//b12N1Y0KGEpBvIDLWGgd1kpcN80Cowx0RLCxOB6KnUxsD0PBNknE5Uxjv9B1QIDAQAB",
        "dmarc_value": "v=DMARC1; p=quarantine; pct=100"
      },
      "results": [
        {
          "type": "TXT",
          "name": "@",
          "ttl": 3600,
          "data": "\"smtpkit-code:4e22f31e3032e7e7d86df7cabc1b8e24\""
        },
        {
          "type": "TXT",
          "name": "@",
          "ttl": 6000,
          "data": "\"v=spf1 v=spf1 a mx include:smtpkit.com  include:*.smtpkit.com -all ~all\""
        },
        {
          "type": "TXT",
          "name": "mail._domainkey",
          "ttl": 3600,
          "data": "\"v=DKIM1; k=rsa; p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC7vJ/Dgoaedp367Fc2xSwzq0liCrVTmLtGGa31D9V0NGu2usNFI+7sGyQQuSjfAsZvFJEdIHIDjA352hKFNuSwRL/517Q114x//alUCwvOx9n//b12N1Y0KGEpBvIDLWGgd1kpcN80Cowx0RLCxOB6KnUxsD0PBNknE5Uxjv9B1QIDAQAB\""
        },
        {
          "type": "TXT",
          "name": "_dmarc",
          "ttl": 3600,
          "data": "\"v=DMARC1; p=quarantine; pct=100\""
        }
      ]
    }
  }
}

Add smtpkit.com template
Copy link

github-actions bot commented Feb 8, 2025

Linter error:

Linter result for smtpkit.com.domain-auth.json
{"level":"error","template":"smtpkit.com.domain-auth.json","groupid":"spfm","record":1,"type":"SPFM","spfRules":"v=spf1","code":"DCTL1017","dctl_note":"spfRules contain invalid data","time":1739047268}
{"level":"error","template":"smtpkit.com.domain-auth.json","groupid":"spfm","record":1,"type":"SPFM","spfRules":"all","code":"DCTL1017","dctl_note":"spfRules contain invalid data","time":1739047268}
{"level":"error","template":"smtpkit.com.domain-auth.json","groupid":"spfm","record":1,"type":"SPFM","data":"v","code":"DCTL1017","dctl_note":"spfRules contain invalid data","time":1739047268}
{"level":"error","template":"smtpkit.com.domain-auth.json","groupid":"spfm","record":1,"type":"SPFM","modifier":"all","code":"DCTL1017","dctl_note":"spfRules contain invalid data","time":1739047268}

"groupId": "spf",
"type": "TXT",
"host": "@",
"data": "%spf_value%",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use SPFM here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants