feat: batch creation of notes from line separated url list #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemens-holleis
force-pushed
the
feat/batch-creation
branch
from
efd8149
to
bda438a
Compare
clemens-holleis
changed the title
adamluckdev
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Thanks for the PR, but it'll need some adjustments. First of all, this approach brings unnecessary ambiguity to function processClipboard.
More cleaner solution is to create new command, with new handling function, for batch creation and possibly new setting for delimiter. New line character as default and comma or semicolon as additional supported delimiters.
src/helpers/fileutils.ts
Outdated
| @@ -2,6 +2,10 @@ import path from 'path'; | |||
| import { normalizePath } from 'obsidian'; | |||
|
|
|||
| export function isValidUrl(url: string): boolean { | |||
| url = url.trim(); | |||
There was a problem hiding this comment.
Input should be sanitized at entry point, not in the function.
| .split('\n') | ||
| .filter((line) => line.trim().length > 0); | ||
| const everyLineIsURL = cleanData.reduce((status: boolean, url: string): boolean => { | ||
| return status && url.substring(0, 4) == 'http'; |
There was a problem hiding this comment.
It would be better to extend isValidUrl helper function with optional argument - array of accepted protocol schemas from new string enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Batch creation of notes from url list. Provide a list of urls where every line is a valid url like below. Each url will be treated individually. So 2 notes will be created
How has this been tested?
manual testing in obsidian with a local build of the addon.
Test data
Valid data for batch processing
Invalid data
Non batch behaviour
batch behaviour
valid dataend up in two individual notesinvalid datawill result in snippet note againTypes of changes
Changes visible to users:
Internal changes:
isValidUrlfromfileutils.tsinParser.tsto eliminate code duplicationisValidUrlgave false positives for multi line input egsome-string\nhttps://www.youtube.com/watch?v=uLMD_u41GlA. Fixed that by trimming the string and returning false immediately if there are still line breaks in the string.Checklist
npm run lint.