Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [4.4.1](https://github.com/DomoApps/ryuu-proxy/compare/v3.1.0...v4.4.1) (2024-10-01)


### Bug Fixes

* **4.3.5:** adjusted paths due to dependency upgrade ([34b6ea3](https://github.com/DomoApps/ryuu-proxy/commit/34b6ea3a3ec34d904e28b1b4d1d7f53f1fb69bc0))

### [4.3.4](https://github.com/DomoApps/ryuu-proxy/compare/v4.3.4-beta.0...v4.3.4) (2023-06-26)

### [4.3.4-beta.0](https://github.com/DomoApps/ryuu-proxy/compare/v3.1.0...v4.3.4-beta.0) (2023-06-08)
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@domoinc/ryuu-proxy",
"version": "4.3.5-beta.2",
"version": "4.4.1",
"description": "a middleware that provides a proxy for local domo app development",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down Expand Up @@ -40,18 +40,18 @@
"@types/node": "^18.0.6",
"@types/sinon": "^10.0.12",
"@types/tough-cookie": "^4.0.2",
"chai": "^4.3.6",
"chai": "^5.0.0",
"mocha": "^10.0.0",
"mock-req": "^0.2.0",
"sinon": "^14.0.0",
"sinon": "^15.0.0",
"standard-version": "^9.5.0",
"ts-node": "^10.9.1",
"tslint-config-airbnb": "^5.11.2",
"tsutils": "^3.21.0",
"typescript": "^4.7.4"
},
"dependencies": {
"axios": "^0.27.2",
"axios": "^0.28.0",
"axios-cookiejar-support": "^1.0.1",
"busboy": "^1.6.0",
"configstore": "^5.0.1",
Expand All @@ -61,9 +61,13 @@
"glob": "^8.0.3",
"https-proxy-agent": "^5.0.1",
"ryuu-client": "^4.3.4-beta.4",
"tough-cookie": "^4.0.0"
"tough-cookie": "^5.0.0"
},
"peerDependencies": {
"ryuu": "^4.2.5"
},
"resolutions": {
"semver": ">=6.3.1",
"braces": ">=3.0.3"
}
}
10 changes: 7 additions & 3 deletions src/index.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as sinon from "sinon";
import * as Domo from "ryuu-client";
import sinon from "sinon";
import Domo from "ryuu-client";
import { expect } from "chai";
import { Proxy } from ".";
import { Manifest } from "./lib/models";
Expand All @@ -13,7 +13,11 @@ describe("Proxy", () => {
id: "test-id",
name: "test-app",
version: "1.0.0",
sizing: { width: 1, height: 1 },
size: { width: 1, height: 1 },
draft: false,
publicAssetsEnabled: true,
flags: new Map(),
fullpage: true,
};

beforeEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as path from "path";
import * as os from "os";
import * as FormData from "form-data";
import FormData from "form-data";
import { createWriteStream, createReadStream } from "fs";
import { Request, Response, NextFunction } from "express";
import { IncomingMessage } from "http";
Expand Down
4 changes: 3 additions & 1 deletion src/lib/models.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { Manifest } from "ryuu-client/lib/models";
import { Manifest as RCManifest } from "ryuu-client/lib/models";

export type Manifest = RCManifest;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this intend to allow access to the manifest from apps in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was actually a TS error since Manifest was not getting re-exported from here but referenced in another file. Either way, it should allow to re-use this library to import the interface, yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and actually, I might also open a patch PR for ryuu-client since the def for Manifest didn't seem accurate from what I saw


export interface ProxyOptions {
manifest: Manifest;
Expand Down
Loading