Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [TreeSelect] Fixed the problem that showFilteredOnly does not ta… #1947

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Nov 30, 2023

…ke effect in TreeSelect controlled expandedKeys

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #1542

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

…ke effect in TreeSelect controlled expandedKeys
Copy link

codesandbox-ci bot commented Nov 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 61229dd:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

Copy link

cypress bot commented Nov 30, 2023

Passing run #2076 ↗︎

0 234 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 61229dd into db8aa50...
Project: semi-design Commit: 7aa86b939f ℹ️
Status: Passed Duration: 10:34 💡
Started: Nov 30, 2023 3:25 AM Ended: Nov 30, 2023 3:35 AM

Review all test suite changes for PR #1947 ↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4c827cc) 88.10% compared to head (7aa86b9) 88.25%.
Report is 12 commits behind head on main.

❗ Current head 7aa86b9 differs from pull request most recent head 61229dd. Consider uploading reports for the commit 61229dd to get more accurate results

Files Patch % Lines
packages/semi-ui/treeSelect/index.tsx 88.88% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
+ Coverage   88.10%   88.25%   +0.14%     
==========================================
  Files         436      436              
  Lines       25568    25604      +36     
  Branches     6450     6463      +13     
==========================================
+ Hits        22527    22597      +70     
+ Misses       3041     3007      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo changed the base branch from main to release December 11, 2023 10:55
@pointhalo pointhalo changed the base branch from release to main December 11, 2023 10:56
@YyumeiZhang YyumeiZhang merged commit 2559649 into main Dec 25, 2023
@YyumeiZhang YyumeiZhang deleted the fix/1542 branch December 25, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Treeselect] <Treeselect> 设置 expandedKeys 时 showFilteredOnly失效
3 participants