Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed TextArea autoSize is not work when textarea resize #2026 #2028

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

shijiatongxue
Copy link
Collaborator

@shijiatongxue shijiatongxue commented Jan 18, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix

PR description

Fixes #2026

变更逻辑:resize 行为由监听 window resize 修改为 textarea resize

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d47919b:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

Copy link

cypress bot commented Jan 18, 2024

Passing run #2187 ↗︎

0 217 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge d47919b into c81cf78...
Project: semi-design Commit: c8fa72ca93 ℹ️
Status: Passed Duration: 08:19 💡
Started: Jan 18, 2024 8:15 AM Ended: Jan 18, 2024 8:23 AM

Review all test suite changes for PR #2028 ↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c81cf78) 87.44% compared to head (c8fa72c) 87.42%.

❗ Current head c8fa72c differs from pull request most recent head d47919b. Consider uploading reports for the commit d47919b to get more accurate results

Files Patch % Lines
packages/semi-ui/input/textarea.tsx 80.95% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
- Coverage   87.44%   87.42%   -0.02%     
==========================================
  Files         437      437              
  Lines       25664    25657       -7     
  Branches     6504     6504              
==========================================
- Hits        22441    22430      -11     
- Misses       3223     3227       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shijiatongxue shijiatongxue merged commit 29a1a80 into main Jan 19, 2024
10 checks passed
@shijiatongxue shijiatongxue deleted the fix/2026 branch January 19, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <TextArea> autosize 未监听文本域宽度变化
4 participants