Update serialization strategy to NOT depend on new lines #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Back in the previous session, when making serialization of constraints, we faced a problem: Mister 10. Because of the dumb serialization strategy being based on separating things on new lines, having integer 10 was a major issue. This PR marks the end of this problem.
Related Issues
(For real now) Close #1.
How to Test
ndf/datafolder.nix develop && just build && ./mainand you should not see any errors.Observations for the Reviewer
As @EduardoLR10 anticipated in issue #1, this was very painful to implement.