Split cleaning logic into functions #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DrKain please review. This is a first pass solution - purely splitting out the functionality from I wasn't able to test as the |
|
This fails several of the example links in the README section. Did you use copilot for this PR? |
Ahh, I missed the examples in the README. Didn't use copilot but wasn't able to test. Let me see what's wrong and fix it up. |
|
@DrKain ok please re-check when you can, found the issue and fixed it: PS: TIL you can perform operations such as // Works
function testPassByRef1(a) {
a.push(4);
a.push(5);
}
// Doesn't work!
function testPassByRef2(a) {
a = ['a', 'b', 'c'];
}
let arr = [1,2,3];
console.log(arr); // [1,2,3]
testPassByRef1(arr);
console.log(arr); // [1,2,3,4,5]
testPassByRef2(arr);
console.log(arr); // [1,2,3,4,5] |
|
At a glance the amazon link is not being cleaned correctly and empty page anchors will still throw an error. As for the array comment you should return the modified data and update accordingly. function testPassByRef1(a) {
a.push(4);
a.push(5);
return a;
}
function testPassByRef2(a) {
a = ['a', 'b', 'c'];
return a;
}
let arr = [1,2,3];
console.log(arr); // [ 1, 2, 3 ]
arr = testPassByRef1(arr);
console.log(arr); // [ 1, 2, 3, 4, 5 ]
arr = testPassByRef2(arr);
console.log(arr); // [ "a", "b", "c" ]This is why your PR is not functioning correctly. |
|
Just letting you know I'll be away for an indeterminate amount of time. If you want to keep working on this PR you're more than welcome to, I will take another look if/when I return. |
|
Closing due to broken code, inactivity, lack of communication and largely outdated handlers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created this PR based on the discussion in #101.
For reference, here are the mappings from the code comments to the 10 items mentioned in the issue. I split into functions the code I found under these comments.