Tests for null and serialize nulls

Draegerwerk · Mar 5, 2025 · e4ae8d8 · e4ae8d8
1 parent 998f5a0
commit e4ae8d8
Show file tree

Hide file tree

Showing 2 changed files with 88 additions and 0 deletions.
diff --git a/sdccc/src/main/java/com/draeger/medical/sdccc/configuration/DefaultTestSuiteModule.java b/sdccc/src/main/java/com/draeger/medical/sdccc/configuration/DefaultTestSuiteModule.java
@@ -64,6 +64,7 @@ protected void configure() {
     @Singleton
     public Gson provideGson() {
         return new GsonBuilder()
+                .serializeNulls()
                 .registerTypeAdapterFactory(new OptionalTypeAdapterFactory())
                 .create();
     }

diff --git a/sdccc/src/test/java/com/draeger/medical/sdccc/manipulation/GRpcManipulationsTest.java b/sdccc/src/test/java/com/draeger/medical/sdccc/manipulation/GRpcManipulationsTest.java
@@ -155,6 +155,93 @@ public void testCreateContextStateWithAssociationDeserialization() {
                 "testContextStateHandle", deserializedResponse.getResponse().get());
     }
 
+    /**
+     * Verifies that a ManipulationResponse with an empty Optional is serialized correctly.
+     */
+    @Test
+    @TestDescription("Verifies that a ManipulationResponse with an empty Optional is serialized correctly")
+    public void testCreateContextStateWithEmptyOptionalSerialization() {
+
+        final ManipulationResponse<Optional<String>> fallbackResponse =
+                ManipulationResponse.from(ResponseTypes.Result.RESULT_SUCCESS, Optional.empty());
+        when(fallback.createContextStateWithAssociation(anyString(), any())).thenReturn(fallbackResponse);
+
+        final ManipulationResponse<Optional<String>> response =
+                manipulations.createContextStateWithAssociation("dummyHandle", ContextAssociation.ASSOC);
+
+        assertEquals(ResponseTypes.Result.RESULT_SUCCESS, response.getResult());
+        assertTrue(response.getResponse().isEmpty());
+    }
+
+    /**
+     * Verifies that a ManipulationResponse with an empty Optional is deserialized correctly.
+     */
+    @Test
+    @TestDescription("Verifies that a ManipulationResponse with an empty Optional is deserialized correctly")
+    public void testCreateContextStateWithEmptyOptionalDeserialization() {
+
+        final ManipulationResponse<Optional<String>> originalResponse =
+                ManipulationResponse.from(ResponseTypes.Result.RESULT_SUCCESS, Optional.empty());
+
+        final Gson gson = new GsonBuilder()
+                .serializeNulls()
+                .registerTypeAdapterFactory(new OptionalTypeAdapterFactory())
+                .create();
+        final GsonManipulationSerializer serializer = new GsonManipulationSerializer(gson);
+
+        final Type type = new TypeToken<ManipulationResponse<Optional<String>>>() {}.getType();
+
+        final String json = serializer.serialize(originalResponse);
+
+        final ManipulationResponse<Optional<String>> deserializedResponse = serializer.deserialize(json, type);
+
+        assertEquals(ResponseTypes.Result.RESULT_SUCCESS, deserializedResponse.getResult());
+        assertTrue(deserializedResponse.getResponse().isEmpty());
+    }
+
+    /**
+     * Verifies that a ManipulationResponse with an Optional containing null is serialized correctly.
+     */
+    @Test
+    @TestDescription("Verifies that a ManipulationResponse with an Optional containing null is serialized correctly")
+    public void testCreateContextStateWithOptionalNullSerialization() {
+
+        final ManipulationResponse<Optional<String>> fallbackResponse =
+                ManipulationResponse.from(ResponseTypes.Result.RESULT_SUCCESS, Optional.ofNullable(null));
+        when(fallback.createContextStateWithAssociation(anyString(), any())).thenReturn(fallbackResponse);
+
+        final ManipulationResponse<Optional<String>> response =
+                manipulations.createContextStateWithAssociation("dummyHandle", ContextAssociation.ASSOC);
+
+        assertEquals(ResponseTypes.Result.RESULT_SUCCESS, response.getResult());
+        assertTrue(response.getResponse().isEmpty());
+    }
+
+    /**
+     * Verifies that a ManipulationResponse with an Optional containing null is deserialized correctly.
+     */
+    @Test
+    @TestDescription("Verifies that a ManipulationResponse with an Optional containing null is deserialized correctly")
+    public void testCreateContextStateWithOptionalNullDeserialization() {
+
+        final ManipulationResponse<Optional<String>> originalResponse =
+                ManipulationResponse.from(ResponseTypes.Result.RESULT_SUCCESS, Optional.ofNullable(null));
+
+        final Gson gson = new GsonBuilder()
+                .serializeNulls()
+                .registerTypeAdapterFactory(new OptionalTypeAdapterFactory())
+                .create();
+        final GsonManipulationSerializer serializer = new GsonManipulationSerializer(gson);
+
+        final Type type = new TypeToken<ManipulationResponse<Optional<String>>>() {}.getType();
+
+        final String json = serializer.serialize(originalResponse);
+        final ManipulationResponse<Optional<String>> deserializedResponse = serializer.deserialize(json, type);
+
+        assertEquals(ResponseTypes.Result.RESULT_SUCCESS, deserializedResponse.getResult());
+        assertTrue(deserializedResponse.getResponse().isEmpty());
+    }
+
     /**
      * Verifies whether data is correctly transmitted to server and results are sent correctly.
      *