Improve the performance and speed of loading large numbers of assets #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
87329 pictures, 1032 videos, iPhone 8, iOS 13.6. Loading time is 11s, please provide me with different test data to help me optimize this part of the function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By replacing
assetArraywithfetchResult, we can optimize the loading performance so that we don't need to get all the assets fromobjects(at: indexSet), but fromobject(at:)according to the actual need. Performance has improved significantly, there is still some unfinished work, I useTODOto mark unfinished work, as the changes are large and require several complete tests to identify potential problems.Very slow opening of picker when media is over 8K #62