Album performance optimization #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify asynchronous fetching of assets within the album list.
|
After this and previous optimizations, now the albums will load and speed in UI display will be much faster than before, after testing. In iPhone 8, iOS 13.6.1, 87898 photos, 1054 videos, the loading time is 3~5s, there are still some problems at this stage, because in addition to the default albums, other albums load asynchronously, which will lead to missing data when viewing all albums, at this time you need to update the data set and UI synchronously when the asynchronous task is complete. |
|
Hi @DragonCherry , I sent you an email with this optimization related question, if you see this comment, please reply to me via email. Thanks. |
|
Hello gezihuzi!
You can contact me via this email anytime. I'm sorry in advance for late response. (I had to look into changes you made these days but I couldn't)
Thank you!
… 2020. 8. 22. 오후 8:14, gezihuzi ***@***.***> :
Hi @DragonCherry , I sent you an email with this optimization related question, if you see this comment, please reply to me via email. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the internal method of
fetchAlbums(forAlbumType type:(to fetch resources only for the default albums using the synchronous method, other albums are fetched asynchronously. This method is not perfect yet, but it has been tested and it works, all that needs to be done now is to update the album list view synchronously when the album information is fetched. I need more people to help me to improve this part of the code or to provide suggestions. Thank you very much.#62