Introduce Stack Reset #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack reset helps reset situation where user may press Ctrl-C in the middle of command and current established session does not close properly. When operating in single session mode, drive shall not let establish another session until sessionTimeout is reached or drive is power cycled (whichever occurs first). Stack Reset helps reset any on going session and able to re-establish session without reaching timeout or physically removing drive (or power cycling the drive). Use of timeout was interesting idea - but a few drives that tested showed min and max SessionTimeout, when configured value in between, session could not be established due to invalid parameters. SessionTimeout is optional implementation, while Stack Reset is required as per spec.
Note: No functionality change expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack reset helps reset situation where user may press Ctrl-C in the middle of command and current established session does not close properly. When operating in single session mode, drive shall not let establish another session until sessionTimeout is reached or drive is power cycled (whichever occurs first).
Stack Reset helps reset any on going session and able to re-establish session without reaching timeout or physically removing drive (or power cycling the drive).
Use of timeout was interesting idea - but a few drives that tested showed min and max SessionTimeout, when configured value in between, session could not be established due to invalid parameters.
SessionTimeout is optional implementation, while Stack Reset is required as per spec.